i18n: Key donate and sponsors, fix navbar, merge master #1457
Conversation
_i18n/en.yml
Outdated
| contribs_handled_by_opencol: "Your contribution to privacytools.io will be handled by the Open Collective Foundation 501(c)(3). For US companies and taxpayers, this means your contribution is" | ||
| tax_deducible: "tax-deductible" | ||
| non_profit_and_anons_no_sponsorship: "As a non-profit, your sponsorship contribution will not be used for private profit and will only be used to cover expenses incurred by the project. All of our transactions (donations and expenses) are published transparently on OpenCollective. For the benefit of our readership, anonymous contributions will not be eligible for the sponsorship opportunities outlined above." |
There was a problem hiding this comment.
These three strings break up one paragraph into three because "tax-deductible" is surrounded with a <strong> tag. Should we just put the entire paragraph in one string opting to include the <strong> tags in en.yml instead?
For context, the entire paragraph is this:
Your contribution to privacytools.io will be handled by the Open Collective Foundation 501(c)(3). For US companies and taxpayers, this means your contribution is tax deductible. As a non-profit, your sponsorship contribution will not be used for private profit and will only be used to cover expenses incurred by the project. All of our transactions (donations and expenses) are published transparently on OpenCollective. For the benefit of our readership, anonymous contributions will not be eligible for the sponsorship opportunities outlined above.
There was a problem hiding this comment.
Yeah... That seems like a better plan, and I'm wondering if we should do that for all the strings we've broken up too 😳
There was a problem hiding this comment.
This is done in privacytoolsIO/privacy-tools@a007e37. (Of course, for those not knowledgeable about HTML, doing this means that we should to advise translators in the future about not translating < ... > contents)
This is a part of https://github.com/privacytoolsIO/privacytools.io/issues/1106. Please take a look at my reviews before merging
Keys the strings of /donate and /sponsors into en.yml; fix some unkeyed strings in navbar; merge master.
PR also fixes Whonix string taking up two lines and some minor punctuation