Skip to content
This repository has been archived by the owner on Jun 24, 2022. It is now read-only.

I18n #1163

Merged
merged 5 commits into from
Aug 16, 2019
Merged

I18n #1163

merged 5 commits into from
Aug 16, 2019

Conversation

yeet648
Copy link
Contributor

@yeet648 yeet648 commented Aug 15, 2019

additional changes for issue #1106. Added tokens for:

  • router-firmware
  • PC OS pages
  • mobile OS

Resolves: #none <!-- The number of the issue that is resolved by this pull request. If there is none, feel free to delete this line

Check List

Code Repository (if applicable):

@yeet648 yeet648 requested a review from a team August 15, 2019 03:30
@jonaharagon jonaharagon self-assigned this Aug 16, 2019
@jonaharagon jonaharagon added the 🇦🇶 translations Anything covering a translated version of the site label Aug 16, 2019
@jonaharagon jonaharagon added this to the i18n milestone Aug 16, 2019
@jonaharagon
Copy link
Contributor

Thank you! Merging this to i18n in a second. One thing, we don't need titles added because the names of things aren't English words. So we don't need lineageos_title: "LineageOS" added, but we do need other headers like mobile_operating_systems: "Mobile Operating Systems", and if the brand name is in a description like lineageos_descr: "LineageOS is a free and open-source... that is good too 👍

@jonaharagon jonaharagon merged commit 2b290bf into privacytools:i18n Aug 16, 2019
@yeet648
Copy link
Contributor Author

yeet648 commented Aug 17, 2019

@jonaharagon got it excluding the product name and also see the global contrib token as well. I will use that on my next update.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
🇦🇶 translations Anything covering a translated version of the site
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants