Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: JSON parsing error is shown when deleting account #55

Merged
merged 4 commits into from
Apr 19, 2024
Merged

Fix: JSON parsing error is shown when deleting account #55

merged 4 commits into from
Apr 19, 2024

Conversation

ivard
Copy link
Member

@ivard ivard commented Apr 18, 2024

No description provided.

@ivard ivard requested review from bobhageman and imre-sidn April 18, 2024 15:51
@imre-sidn
Copy link

Same issue as the one fixed in #43

imre-sidn
imre-sidn requested changes Apr 18, 2024
View reviewed changes
Copy link

@imre-sidn imre-sidn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

as you mentioned @ivard, the current fix breaks revalidate mail error flow

@ivard
Copy link
Member Author

ivard commented Apr 18, 2024 •
edited
Loading

as you mentioned @ivard, the current fix breaks revalidate mail error flow

Fixed it in the same manner as in #43 .

@ivard ivard merged commit 3c9b260 into master Apr 19, 2024
2 checks passed
@ivard ivard deleted the fix-delete-account branch April 19, 2024 09:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@imre-sidn imre-sidn imre-sidn requested changes

@bobhageman bobhageman bobhageman approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ivard @imre-sidn @bobhageman