Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have fixed the import error caused by an existing
properties.calc.json
as described in #320. I fixed the segfault for empty force in #313. For an emptyvalue
field like this:the import will fail, but there is now an error message instead of a segfault. If
value
is missing there will also be an error message and the import will fail. The import is already successful if there is noforce
field, but now I have hardcodedforce
to be always optional, so the import will work for the above JSON. This seems a bit risky - it would probably be better to pass a list of optional properties.I also updated some documentation:
import_properties
is false by defaultadditional_files
tocopy_additional_files
copy_additional_files
requirescopy_structure_files
copy_structure_files
impliesimport_properties
because it copiesproperties.calc.json
Two things that I did not address are that the
copy_additional_files
option prints every copied file to stdout, which is a lot of printing, and the documentation forcp_files
says that it returns whether or not files were copied, but I don't think that it does.