Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: nanoid() schema function #4367

Closed
wants to merge 1 commit into from
Closed

Conversation

rintaun
Copy link

@rintaun rintaun commented Jan 6, 2023

Describe this PR

Documents the newly added nanoid() function

Changes

  • Add nanoid() where cuid()/uuid() are mentioned in relevant contexts

What issue does this fix?

Fixes #4363

@vercel
Copy link

vercel bot commented Jan 6, 2023

@rintaun is attempting to deploy a commit to the Prisma Team on Vercel.

A member of the Team first needs to authorize it.

@rintaun
Copy link
Author

rintaun commented Jan 6, 2023

@pimeys @janpio I think I've added the most important bits. Please let me know if I've missed anything!

@janpio janpio self-requested a review January 9, 2023 09:47
@janpio
Copy link
Contributor

janpio commented Jan 9, 2023

Note for docs team: Implementation is not finished yet, so not to be merged yet.

@vercel
Copy link

vercel bot commented Jan 11, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
docs ✅ Ready (Inspect) Visit Preview Jan 11, 2023 at 10:23AM (UTC)

@nikolasburk
Copy link
Member

What's the status of the nanoid() implementation? Is it still being worked on or should we close this PR?

@Jolg42 Jolg42 marked this pull request as draft November 16, 2023 16:10
@Jolg42
Copy link
Contributor

Jolg42 commented Nov 16, 2023

@nikolasburk I made this PR a draft for now. This is blocked by some work that still needs to happen but is currently not planned, see prisma/prisma#17199 for more details.

@nikolasburk
Copy link
Member

I would actually close this one @Jolg42. When we know that nanoid() is coming, we can make a fresh plan for documenting it. (This current PR will be a pain to merge anyways due to the merge conflicts and all the changes that have happened to the content since the PR was opened.)

@Jolg42 Jolg42 closed this Nov 27, 2023
@janpio
Copy link
Contributor

janpio commented Nov 27, 2023

As written in DM as well, I disagree with this. Someone invested a lot of time and effort to find all the places where this should be documented. At least we should turn this into an issue and link this PR here so there is a chance of this being found again for when we need all these locations.

@Jolg42
Copy link
Contributor

Jolg42 commented Nov 27, 2023

@janpio I closed it because it's already linked in prisma/prisma#17199.
Feel free to re-open if you want.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Nanoid default value
4 participants