Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable GPU support in WSL #342

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Enable GPU support in WSL #342

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
521d22f
Detect nvidia smi path properly if using WSL
RaiaN Oct 6, 2024
d66c78b
Properly detect path to nvidia-smi
RaiaN Oct 6, 2024
05b48a9
Delete infinigen/datagen/util/is_wsl.py
RaiaN Oct 6, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 17 additions & 5 deletions infinigen/datagen/util/submitit_emulator.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,7 @@
import itertools
import logging
import os
import platform
import re
import subprocess
import sys
Expand All @@ -26,6 +27,14 @@

CUDA_VARNAME = "CUDA_VISIBLE_DEVICES"
NVIDIA_SMI_PATH = "/bin/nvidia-smi"
NVIDIA_SMI_WSL_PATH = "/usr/lib/wsl/lib/nvidia-smi"

def is_wsl(v: str = platform.uname().release) -> int:
# WSL v1 and v2
if v.endswith("-Microsoft") or v.endswith("microsoft-standard-WSL2"):
return True

return False


@dataclass
Expand Down Expand Up @@ -131,10 +140,11 @@ def instance(cls):
cls._inst = cls()
return cls._inst

def __init__(self, jobs_per_gpu=1, use_gpu=True):
def __init__(self, jobs_per_gpu=1, use_gpu=True, nvidia_smi_path=None):
self.queue = []
self.jobs_per_gpu = jobs_per_gpu
self.use_gpu = use_gpu
self.nvidia_smi_path = nvidia_smi_path

def enqueue(self, func, args, kwargs, params, log_folder):
job = LocalJob(job_id=get_fake_job_id(), process=None)
Expand All @@ -156,13 +166,15 @@ def total_resources(self):
resources = {}

if self.use_gpu:
if which(NVIDIA_SMI_PATH) is None:
nvidia_smi_path = self.nvidia_smi_path or (NVIDIA_SMI_WSL_PATH if is_wsl() else NVIDIA_SMI_PATH)

if which(nvidia_smi_path) is None:
raise ValueError(
f"LocalScheduleHandler.use_gpu=True yet could not find {NVIDIA_SMI_PATH}, "
"please use --pipeline_overrides LocalScheduleHandler.use_gpu=False if your machine does not have a supported GPU"
f"LocalScheduleHandler.use_gpu=True yet could not find `nvidia-smi` by this path: {nvidia_smi_path} "
"Please use --pipeline_overrides LocalScheduleHandler.use_gpu=False if your machine does not have a supported GPU"
)

result = subprocess.check_output(f"{NVIDIA_SMI_PATH} -L".split()).decode()
result = subprocess.check_output(f"{nvidia_smi_path} -L".split()).decode()
gpus_uuids = set(i for i in range(len(result.splitlines())))

if CUDA_VARNAME in os.environ:
Expand Down