Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow setting custom values on submit buttons #3141

Merged
merged 2 commits into from
Oct 14, 2024
Merged

Conversation

camertron
Copy link
Contributor

What are you trying to accomplish?

It's currently not possible to set a custom value on a submit button in the Primer forms framework, an oversight this PR addresses.

Integration

No changes necessary in production.

List the issues that this change affects.

Fixes #3129

Risk Assessment

  • Low risk the change is small, highly observable, and easily rolled back.
  • Medium risk changes that are isolated, reduced in scope or could impact few users. The change will not impact library availability.
  • High risk changes are those that could impact customers and SLOs, low or no test coverage, low observability, or slow to rollback.

Accessibility

  • No new axe scan violation - This change does not introduce any new axe scan violations.

Copy link

changeset-bot bot commented Oct 7, 2024

🦋 Changeset detected

Latest commit: c1129d7

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@primer/view-components Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@camertron camertron marked this pull request as ready for review October 8, 2024 17:53
@camertron camertron requested a review from a team as a code owner October 8, 2024 17:53
@camertron camertron requested review from joshblack and jonrohan and removed request for joshblack October 8, 2024 17:53
@camertron camertron merged commit 37e78c0 into main Oct 14, 2024
34 checks passed
@camertron camertron deleted the submit_button_values branch October 14, 2024 18:23
@primer primer bot mentioned this pull request Oct 14, 2024
@camertron camertron mentioned this pull request Oct 15, 2024
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Button that submits a value
2 participants