Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce the Stack and StackItem components #3126

Merged
merged 36 commits into from
Oct 4, 2024
Merged

Introduce the Stack and StackItem components #3126

merged 36 commits into from
Oct 4, 2024

Conversation

francinelucca
Copy link
Member

@francinelucca francinelucca commented Sep 30, 2024

What are you trying to accomplish?

Introduces the Stack and StackItem components, aiming for feature-parity with PRC

Screenshots

Screen.Recording.2024-10-03.at.1.37.57.PM.mov
Screen.Recording.2024-10-03.at.1.36.55.PM.mov

Integration

No changes necessary in production.

Risk Assessment

  • Low risk the change is small, highly observable, and easily rolled back.
  • Medium risk changes that are isolated, reduced in scope or could impact few users. The change will not impact library availability.
  • High risk changes are those that could impact customers and SLOs, low or no test coverage, low observability, or slow to rollback.

introduces new component, should not affect/modify any currently existing functionality

What approach did you choose and why?

  • Added component, css and template files for Stack & StackItem
  • Imported new css files into primer.pcss
  • Introduced new ResponsiveArg class to aid in handling responsive arguments by breakpoint
  • Added Default & Playground stories for new components
  • Wrote exhaustive tests for both Stack and StackItem

Anything you want to highlight for special attention from reviewers?

N/A

Accessibility

  • No new axe scan violation - This change does not introduce any new axe scan violations.

Merge checklist

  • Added/updated tests
  • Added/updated documentation
  • Added/updated previews (Lookbook)
  • Tested in Chrome
  • Tested in Firefox
  • Tested in Safari
  • Tested in Edge

Take a look at the What we look for in reviews section of the contributing guidelines for more information on how we review PRs.

Copy link

changeset-bot bot commented Sep 30, 2024

🦋 Changeset detected

Latest commit: e481823

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@primer/view-components Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@francinelucca francinelucca changed the title wip(Stack): base files wip: Stack Sep 30, 2024
@camertron camertron changed the title wip: Introduce the Stack and StackItem components Introduce the Stack and StackItem components Oct 2, 2024
@camertron camertron marked this pull request as ready for review October 2, 2024 22:43
@camertron camertron requested review from a team as code owners October 2, 2024 22:43
@camertron camertron requested review from lukasoppermann and joshblack and removed request for a team October 2, 2024 22:43
Copy link
Member

@joshblack joshblack left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very cool! 🥳

Copy link
Contributor

@camertron camertron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

@francinelucca francinelucca merged commit 89052ca into main Oct 4, 2024
35 checks passed
@francinelucca francinelucca deleted the feat/stack branch October 4, 2024 17:32
@primer primer bot mentioned this pull request Oct 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants