Remove aria-disabled from dialogs #2579
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Authors: Please fill out this form carefully and completely.
Reviewers: By approving this Pull Request you are approving the code change, as well as its deployment and mitigation plans.
Please read this description carefully. If you feel there is anything unclear or missing, please ask for updates.
What are you trying to accomplish?
In #1891 we added
aria-disabled=true
to::Dialog
. This attribute makes the dialog and all children unavailable to ATs. This is far from ideal. In #1996 we changed this to ensure that the Dialog, when open, toggled itsaria-disabled
flag fromtrue
tofalse
. This was better.In #2364 we moved from our custom
<modal-dialog>
to native<dialog>
, and somehow thearia-disabled=true
fixed flag returned.This PR removes it entirely. I do not know of a good reason to keep it,
<dialog>
should be AT friendly so we shouldn't need to do aria shenanigans.Screenshots
N/A
Integration
N/A
List the issues that this change affects.
#2578
Risk Assessment
What approach did you choose and why?
Remove the aria attribute.
Anything you want to highlight for special attention from reviewers?
If you can think of a good reason to keep this attribute I'd love to know it!
Accessibility
Merge checklist
Take a look at the What we look for in reviews section of the contributing guidelines for more information on how we review PRs.