Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert "refactor Dialog to use <dialog> internally" #2468

Merged
merged 3 commits into from
Dec 19, 2023
Merged

Revert "refactor Dialog to use <dialog> internally" #2468

merged 3 commits into from
Dec 19, 2023

Conversation

camertron
Copy link
Contributor

Reverts #2364, which has resulted in the following behavior in dotcom:

A screenshot of a logged-in github.com showing the global side nav floated in the middle of the page instead of attached to the right-hand side.

@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Dec 19, 2023 •
edited
Loading

⚠️ No Changeset found

Latest commit: fdbf36a

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@camertron camertron mentioned this pull request Dec 19, 2023
Merged
10 tasks
@camertron camertron added the skip changeset Pull requests that don't change the library output label Dec 19, 2023
@camertron camertron marked this pull request as ready for review December 19, 2023 23:15
@camertron camertron requested a review from a team as a code owner December 19, 2023 23:15
@camertron camertron requested review from a team, lukasoppermann and keithamus December 19, 2023 23:15
@camertron camertron merged commit 0a25f58 into main Dec 19, 2023
29 of 30 checks passed
@camertron camertron deleted the revert_2364 branch December 19, 2023 23:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lukasoppermann lukasoppermann Awaiting requested review from lukasoppermann lukasoppermann is a code owner automatically assigned from primer/css-reviewers

@keithamus keithamus Awaiting requested review from keithamus

Assignees
No one assigned
Labels
skip changeset Pull requests that don't change the library output
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@camertron