-
Notifications
You must be signed in to change notification settings - Fork 116
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updates 'inactive' state for buttons #2379
Conversation
🦋 Changeset detectedLatest commit: 60f0916 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
… mp/inactive-button-a11y-updates
|
…primer/view_components into mp/inactive-button-a11y-updates
Holding off on merging this for now. We may need another |
… mp/inactive-button-a11y-updates
|
… mp/inactive-button-a11y-updates
Authors: Please fill out this form carefully and completely.
Reviewers: By approving this Pull Request you are approving the code change, as well as its deployment and mitigation plans.
Please read this description carefully. If you feel there is anything unclear or missing, please ask for updates.
What are you trying to accomplish?
Implements feedback from a11y team:
aria-disabled
since they can still accept interactions such as:Screenshots
Integration
@primer/primitives
to7.15.1
List the issues that this change affects.
Relates to https://github.com/github/primer/issues/2676
Risk Assessment
What approach did you choose and why?
Add a new class that styles all button variants' "inactive" state the same.
Anything you want to highlight for special attention from reviewers?
Can't think of anything
Accessibility
Merge checklist
Take a look at the What we look for in reviews section of the contributing guidelines for more information on how we review PRs.