Merge branch 'main' into fix/space-in-form

.changeset/bright-eggs-return.md

@@ -0,0 +1,5 @@
+---
+'@primer/view-components': patch
+---
+
+Moves the loading and "no results" messages on the SelectPanel to the top of the container.

.changeset/chatty-apples-hope.md

@@ -0,0 +1,6 @@
+---
+'@primer/view-components': minor
+---
+
+[SelectPanel] replace loading label using parameter loading_label
+[SelectPanel] show additional loading content with loading_description

.changeset/cuddly-games-prove.md

@@ -0,0 +1,5 @@
+---
+'@primer/view-components': patch
+---
+
+Allow setting custom values on submit buttons.

.changeset/four-steaks-shake.md

@@ -0,0 +1,5 @@
+---
+'@primer/view-components': minor
+---
+
+Add option to Dialog to permit/disable page scrolling

.changeset/heavy-camels-hear.md

@@ -0,0 +1,5 @@
+---
+'@primer/view-components': patch
+---
+
+Fix problem introduced by #3141 that causes template captions not to render for certain input types if the input is configured with a `value:`.

.changeset/hip-deers-rhyme.md

@@ -0,0 +1,5 @@
+---
+'@primer/view-components': minor
+---
+
+Allow form groups to accept system arguments

.changeset/lemon-kiwis-learn.md

@@ -0,0 +1,5 @@
+---
+"@primer/view-components": patch
+---
+
+Add "action" to the list of data attributes that accept multiple values in the `merge_data` helper

.changeset/shy-schools-grow.md

@@ -0,0 +1,5 @@
+---
+'@primer/view-components': minor
+---
+
+Introduce the Stack and StackItem components.

.changeset/sweet-donkeys-allow.md

@@ -0,0 +1,5 @@
+---
+'@primer/view-components': patch
+---
+
+Clear input on SelectPanel when dialog closed

.changeset/three-readers-switch.md

@@ -0,0 +1,5 @@
+---
+'@primer/view-components': minor
+---
+
+[SelectPanel] Adds banner scheme as param.

.changeset/tough-actors-wait.md

@@ -0,0 +1,5 @@
+---
+"@primer/view-components": patch
+---
+
+Fix bug where checkboxes were broken with prefers-reduced-motion

.changeset/wicked-bananas-tie.md

@@ -0,0 +1,5 @@
+---
+'@primer/view-components': patch
+---
+
+Remove dialog-scrollgutter setting from hot-path, for improved performance

.devcontainer/devcontainer.json

@@ -13,25 +13,29 @@
   },
   "onCreateCommand": ".devcontainer/on-create-command.sh",
   "postCreateCommand": ".devcontainer/post-create-command.sh",
-  "settings": {
-    "files.watcherExclude": {
-      "**/vendor": true,
-      "**/.git": true,
-      "**/tmp": true,
-      "**/node_modules": true
-    }
+  "customizations": {
+    "settings": {
+      "files.watcherExclude": {
+        "**/vendor": true,
+        "**/.git": true,
+        "**/tmp": true,
+        "**/node_modules": true
+      }
+    },
+    "extensions": [
+      "castwide.solargraph",
+      "kaiwood.endwise",
+      "manuelpuyol.erb-linter",
+      "misogi.ruby-rubocop",
+      "rebornix.ruby",
+      "wingrunr21.vscode-ruby",
+      "mutantdino.resourcemonitor",
+      "vunguyentuan.vscode-postcss",
+      "DavidAnson.vscode-markdownlint",
+      "stylelint.vscode-stylelint",
+      "hex-ci.stylelint-plus"
+    ]
   },
-  "extensions": [
-    "castwide.solargraph",
-    "kaiwood.endwise",
-    "manuelpuyol.erb-linter",
-    "misogi.ruby-rubocop",
-    "rebornix.ruby",
-    "wingrunr21.vscode-ruby",
-    "mutantdino.resourcemonitor",
-    "vunguyentuan.vscode-postcss",
-    "DavidAnson.vscode-markdownlint"
-  ],
   "forwardPorts": [4000],
   "appPort": [4000],
   "portsAttributes": {

.erb-lint.yml

@@ -27,7 +27,7 @@ linters:
         Enabled: false
         Exclude:
           - app/components/primer/layout_component.html.erb
-      Primer/Migrations/IconButtonComponent:
+      Migrations/IconButtonComponent:
         Enabled: true
-      Primer/Migrations/TruncateComponent:
+      Migrations/TruncateComponent:
         Enabled: true

.github/release_template.md

@@ -21,4 +21,8 @@ Please ensure these items are checked before merging.
 - [ ] No noticeable regressions have been introduced as a result of changes in this release
 - [ ] Release notes accurately describe the changes made
 
+### 🚢 Post ship reminders
+
+- [ ] Deploy lookbook via chat ops in the #primer-rails-ops channel. `.deploy primer-lookbook to production`
+
 Please also leave any testing notes as a comment on this pull request. In particular, describing any issues encountered during your testing. This is helpful in providing historical context to maintainers.

.github/workflows/demo-preview-cleanup.yml

@@ -27,9 +27,9 @@ jobs:
         with:
           # excluding a client secret here will cause a login via OpenID Connect (OIDC),
           # which prevents us from having to rotate client credentials, etc
-          client-id: "5ad1a188-b944-40eb-a2f8-cc683a6a65a0"
-          tenant-id: "398a6654-997b-47e9-b12b-9515b896b4de"
-          subscription-id: "550eb99d-d0c7-4651-a337-f53fa6520c4f"
+          client-id: ${{ secrets.AZURE_CLIENT_ID }}
+          tenant-id: ${{ secrets.AZURE_TENANT_ID }}
+          subscription-id: ${{ secrets.AZURE_SUBSCRIPTION_ID }}
 
       # Do this before repo checkout to prevent running bundle install
       - uses: ruby/setup-ruby@v1

.github/workflows/demo-preview-destroy.yml

@@ -31,9 +31,9 @@ jobs:
         with:
           # excluding a client secret here will cause a login via OpenID Connect (OIDC),
           # which prevents us from having to rotate client credentials, etc
-          client-id: "5ad1a188-b944-40eb-a2f8-cc683a6a65a0"
-          tenant-id: "398a6654-997b-47e9-b12b-9515b896b4de"
-          subscription-id: "550eb99d-d0c7-4651-a337-f53fa6520c4f"
+          client-id: ${{ secrets.AZURE_CLIENT_ID }}
+          tenant-id: ${{ secrets.AZURE_TENANT_ID }}
+          subscription-id: ${{ secrets.AZURE_SUBSCRIPTION_ID }}
 
       - name: Check out repo
         uses: actions/checkout@v4

.github/workflows/demo-production-deploy.yml

@@ -32,9 +32,9 @@ jobs:
       with:
         # excluding a client secret here will cause a login via OpenID Connect (OIDC),
         # which prevents us from having to rotate client credentials, etc
-        client-id: "5ad1a188-b944-40eb-a2f8-cc683a6a65a0"
-        tenant-id: "398a6654-997b-47e9-b12b-9515b896b4de"
-        subscription-id: "550eb99d-d0c7-4651-a337-f53fa6520c4f"
+        client-id: ${{ secrets.AZURE_CLIENT_ID }}
+        tenant-id: ${{ secrets.AZURE_TENANT_ID }}
+        subscription-id: ${{ secrets.AZURE_SUBSCRIPTION_ID }}
     - name: Purge tags
       run: |
         # only delete tags that aren't "latest" or "latest-assets"
@@ -84,13 +84,16 @@ jobs:
       with:
         # excluding a client secret here will cause a login via OpenID Connect (OIDC),
         # which prevents us from having to rotate client credentials, etc
-        client-id: "5ad1a188-b944-40eb-a2f8-cc683a6a65a0"
-        tenant-id: "398a6654-997b-47e9-b12b-9515b896b4de"
-        subscription-id: "550eb99d-d0c7-4651-a337-f53fa6520c4f"
+        client-id: ${{ secrets.AZURE_CLIENT_ID }}
+        tenant-id: ${{ secrets.AZURE_TENANT_ID }}
+        subscription-id: ${{ secrets.AZURE_SUBSCRIPTION_ID }}
     - name: Deploy
       env:
         RAILS_MASTER_KEY: ${{ secrets.RAILS_MASTER_KEY }}
         AZURE_ACR_PASSWORD: ${{ secrets.AZURE_ACR_PASSWORD }}
+        AZURE_SUBSCRIPTION_ID: ${{ secrets.AZURE_SUBSCRIPTION_ID }}
+        AZURE_TENANT_ID: ${{ secrets.AZURE_TENANT_ID }}
+        AZURE_CLIENT_ID: ${{ secrets.AZURE_CLIENT_ID }}
       run: |
-        export AZURE_ACCESS_TOKEN=$(az account get-access-token --subscription 550eb99d-d0c7-4651-a337-f53fa6520c4f | jq -r .accessToken)
+        export AZURE_ACCESS_TOKEN=$(az account get-access-token --subscription ${{ secrets.AZURE_SUBSCRIPTION_ID }} | jq -r .accessToken)
         bin/kuby -e production deploy

.github/workflows/lint.yml

@@ -12,7 +12,7 @@ jobs:
     - uses: actions/checkout@v4
     - name: Get specific changed files
       id: changed-files
-      uses: tj-actions/[email protected].1
+      uses: tj-actions/[email protected].2
       with:
         files: |
           docs/**/*.md
@@ -25,7 +25,6 @@ jobs:
     - uses: actions/setup-node@v4
       if: steps.changed-files.outputs.any_changed == 'true'
       with:
-        node-version: 16
         cache: 'npm'
     - name: Lint with Markdownlint
       if: steps.changed-files.outputs.any_changed == 'true'
@@ -39,57 +38,50 @@ jobs:
     - uses: actions/checkout@v4
     - name: Get specific changed files
       id: changed-files
-      uses: tj-actions/[email protected].1
+      uses: tj-actions/[email protected].2
       with:
         files: |
           app/**/*.rb
           lib/**/*.rb
           demo/**/*.rb
           test/**/*.rb
     - uses: ruby/setup-ruby@v1
-      if: steps.changed-files.outputs.any_changed == 'true'
       with:
         ruby-version: '3.3'
         bundler-cache: true
     - name: Lint with Rubocop
-      if: steps.changed-files.outputs.any_changed == 'true'
-      run: |
-        bundle exec rubocop ${{ steps.changed-files.outputs.all_changed_files }} --format github
+      run: script/rubocop --format github
 
   erblint:
     runs-on: ubuntu-latest
     steps:
     - uses: actions/checkout@v4
     - name: Get changed files
       id: changed-files
-      uses: tj-actions/[email protected].1
+      uses: tj-actions/[email protected].2
       with:
         files: |
           app/components/**/*.erb
     - uses: ruby/setup-ruby@v1
-      if: steps.changed-files.outputs.any_changed == 'true'
       with:
         ruby-version: '3.3'
         bundler-cache: true
     - name: Lint with ERB Lint
-      if: steps.changed-files.outputs.any_changed == 'true'
-      run: |
-        bundle exec erblint ${{ steps.changed-files.outputs.all_changed_files }} --format github
+      run: script/erblint --format github
 
   eslint:
     runs-on: ubuntu-latest
     steps:
     - uses: actions/checkout@v4
     - name: Get changed files
       id: changed-files
-      uses: tj-actions/[email protected].1
+      uses: tj-actions/[email protected].2
       with:
         files: |
           app/components/**/*.ts
     - uses: actions/setup-node@v4
       if: steps.changed-files.outputs.any_changed == 'true'
       with:
-        node-version: 16
         cache: 'npm'
     - name: Lint with ESLint
       if: steps.changed-files.outputs.any_changed == 'true'
@@ -103,18 +95,17 @@ jobs:
     - uses: actions/checkout@v4
     - name: Get changed files
       id: changed-files
-      uses: tj-actions/[email protected].1
+      uses: tj-actions/[email protected].2
       with:
         files: |
           app/components/**/*.pcss
           lib/postcss_mixins/*.pcss
     - uses: actions/setup-node@v4
       if: steps.changed-files.outputs.any_changed == 'true'
       with:
-        node-version: 16
         cache: 'npm'
     - name: Lint with Stylelint
       if: steps.changed-files.outputs.any_changed == 'true'
       run: |
         npm ci
-        npx stylelint ${{ steps.changed-files.outputs.all_changed_files }} -f "github"
+        npx stylelint --rd -q ${{ steps.changed-files.outputs.all_changed_files }} --custom-formatter=stylelint-actions-formatters

.github/workflows/preview-deploy.yml

@@ -62,9 +62,9 @@ jobs:
       with:
         # excluding a client secret here will cause a login via OpenID Connect (OIDC),
         # which prevents us from having to rotate client credentials, etc
-        client-id: "5ad1a188-b944-40eb-a2f8-cc683a6a65a0"
-        tenant-id: "398a6654-997b-47e9-b12b-9515b896b4de"
-        subscription-id: "550eb99d-d0c7-4651-a337-f53fa6520c4f"
+        client-id: ${{ secrets.AZURE_CLIENT_ID }}
+        tenant-id: ${{ secrets.AZURE_TENANT_ID }}
+        subscription-id: ${{ secrets.AZURE_SUBSCRIPTION_ID }}
 
     - name: Get preview app info
       run: ./.github/workflows/demo-preview-app-info.sh
@@ -96,7 +96,7 @@ jobs:
       uses: azure/arm-deploy@a1361c2c2cd398621955b16ca32e01c65ea340f5
       with:
         resourceGroupName: primer
-        subscriptionId: 550eb99d-d0c7-4651-a337-f53fa6520c4f
+        subscriptionId: ${{ secrets.AZURE_SUBSCRIPTION_ID }}
         template: ./.github/workflows/demo-preview-template.json
         deploymentName: ${{env.DEPLOYMENT_NAME}}
         parameters: appName="${{env.APP_NAME}}"

.github/workflows/test.yml

@@ -55,8 +55,6 @@ jobs:
             ruby_version: "3.2"
           - rails_version: "7.1.3"
             ruby_version: "3.3"
-          - rails_version: "main"
-            ruby_version: "3.1"
           - rails_version: "main"
             ruby_version: "3.2"
           - rails_version: "main"
@@ -103,8 +101,6 @@ jobs:
             ruby_version: "3.2"
           - rails_version: "7.1.3"
             ruby_version: "3.3"
-          - rails_version: "main"
-            ruby_version: "3.1"
           - rails_version: "main"
             ruby_version: "3.2"
           - rails_version: "main"
@@ -151,8 +147,6 @@ jobs:
             ruby_version: "3.2"
           - rails_version: "7.1.3"
             ruby_version: "3.3"
-          - rails_version: "main"
-            ruby_version: "3.1"
           - rails_version: "main"
             ruby_version: "3.2"
           - rails_version: "main"
@@ -258,7 +252,7 @@ jobs:
     - name: Run Playwright tests
       id: playwright-run
       continue-on-error: true
-      run: npx playwright test --workers 6
+      run: ./script/run-playwright
     - id: auto-commit
       uses: stefanzweifel/git-auto-commit-action@v5
       with:

.gitignore

@@ -5,11 +5,11 @@ app/components/**/*.css.json
 app/components/**/*.css.map
 app/components/**/*.d.ts
 app/lib/primer/css/*.css.json
-lib/primer/forms/**/*.js
-lib/primer/forms/**/*.css
-lib/primer/forms/**/*.css.json
-lib/primer/forms/**/*.css.map
-lib/primer/forms/**/*.d.ts
+app/lib/primer/forms/**/*.js
+app/lib/primer/forms/**/*.css
+app/lib/primer/forms/**/*.css.json
+app/lib/primer/forms/**/*.css.map
+app/lib/primer/forms/**/*.d.ts
 app/assets/
 
 # Generated by demo npm post-install