Merge branch 'mp/inactive-button-a11y-updates' of https://github.com/…

…primer/view_components into mp/inactive-button-a11y-updates
primer · Nov 15, 2023 · 612d48c · 612d48c
2 parents 4198eb4 + 924f9bc
commit 612d48c
Show file tree

Hide file tree

Showing 4 changed files with 11 additions and 0 deletions.
diff --git a/.changeset/lovely-suits-drop.md b/.changeset/lovely-suits-drop.md
@@ -0,0 +1,11 @@
+---
+"@primer/view-components": patch
+---
+
+Updates 'inactive' state for buttons based on feedback from the a11y team:
+- inactive buttons need to meet the color contrast ratio minimum
+- inactive buttons shouldn't have aria-disabled since they can still accept interactions such as:
+  - hover/focus to show a tooltip
+  - click/activate to show a dialog with more detailed info on why it's inactive
+
+<!-- Changed components: Button -->
diff --git a/...enshots/snapshots.test.ts-snapshots/primer/alpha/banner/dismissible/default.png b/...enshots/snapshots.test.ts-snapshots/primer/alpha/banner/dismissible/default.png
diff --git a/...screenshots/snapshots.test.ts-snapshots/primer/beta/button/inactive/default.png b/...screenshots/snapshots.test.ts-snapshots/primer/beta/button/inactive/default.png
diff --git a/...screenshots/snapshots.test.ts-snapshots/primer/beta/button/inactive/focused.png b/...screenshots/snapshots.test.ts-snapshots/primer/beta/button/inactive/focused.png