Skip to content

refactor Dialog to use <dialog> internally #4571

refactor Dialog to use <dialog> internally

refactor Dialog to use <dialog> internally #4571

Triggered via pull request November 9, 2023 15:58
Status Cancelled
Total duration 1m 46s
Artifacts

test.yml

on: pull_request
Matrix: Components
Matrix: Lib
Matrix: Performance
Fit to window
Zoom out
Zoom in

Annotations

156 errors
Components (7.0.3, 3.0): app/components/primer/dialog_helpers.ts#L46
Parameter 'event' implicitly has an 'any' type.
Components (7.0.3, 3.0): app/components/primer/dialog_helpers.ts#L49
'dialog' is possibly 'null'.
Components (7.0.3, 3.0): app/components/primer/dialog_helpers.ts#L52
'dialog' is possibly 'null'.
Components (7.0.3, 3.0): app/components/primer/dialog_helpers.ts#L60
'dialog' is possibly 'null'.
Components (7.0.3, 3.0): app/components/primer/dialog_helpers.ts#L75
Property 'ModalDialogElement' does not exist on type 'Window & typeof globalThis'. Did you mean 'HTMLDialogElement'?
Components (7.0.3, 3.0): node_modules/@oddbird/popover-polyfill/dist/index.d.ts#L7
All declarations of 'oldState' must have identical modifiers.
Components (7.0.3, 3.0): node_modules/@oddbird/popover-polyfill/dist/index.d.ts#L8
All declarations of 'newState' must have identical modifiers.
Components (7.0.3, 3.0): node_modules/@oddbird/popover-polyfill/dist/index.d.ts#L11
Subsequent property declarations must have the same type. Property 'popover' must be of type 'string | null', but here has type '"auto" | "manual" | null'.
Components (7.0.3, 3.0): node_modules/typescript/lib/lib.dom.d.ts#L9683
Interface 'HTMLButtonElement' cannot simultaneously extend types 'PopoverInvokerElement' and 'PopoverToggleTargetElementInvoker'.
Lib (7.0.3, 3.0): app/components/primer/dialog_helpers.ts#L46
Parameter 'event' implicitly has an 'any' type.
Lib (7.0.3, 3.0): app/components/primer/dialog_helpers.ts#L49
'dialog' is possibly 'null'.
Lib (7.0.3, 3.0): app/components/primer/dialog_helpers.ts#L52
'dialog' is possibly 'null'.
Lib (7.0.3, 3.0): app/components/primer/dialog_helpers.ts#L60
'dialog' is possibly 'null'.
Lib (7.0.3, 3.0): app/components/primer/dialog_helpers.ts#L75
Property 'ModalDialogElement' does not exist on type 'Window & typeof globalThis'. Did you mean 'HTMLDialogElement'?
Lib (7.0.3, 3.0): node_modules/@oddbird/popover-polyfill/dist/index.d.ts#L7
All declarations of 'oldState' must have identical modifiers.
Lib (7.0.3, 3.0): node_modules/@oddbird/popover-polyfill/dist/index.d.ts#L8
All declarations of 'newState' must have identical modifiers.
Lib (7.0.3, 3.0): node_modules/@oddbird/popover-polyfill/dist/index.d.ts#L11
Subsequent property declarations must have the same type. Property 'popover' must be of type 'string | null', but here has type '"auto" | "manual" | null'.
Lib (7.0.3, 3.0): node_modules/typescript/lib/lib.dom.d.ts#L9683
Interface 'HTMLButtonElement' cannot simultaneously extend types 'PopoverInvokerElement' and 'PopoverToggleTargetElementInvoker'.
Components (6.1.1, 2.7): app/components/primer/dialog_helpers.ts#L46
Parameter 'event' implicitly has an 'any' type.
Components (6.1.1, 2.7): app/components/primer/dialog_helpers.ts#L49
'dialog' is possibly 'null'.
Components (6.1.1, 2.7): app/components/primer/dialog_helpers.ts#L52
'dialog' is possibly 'null'.
Components (6.1.1, 2.7): app/components/primer/dialog_helpers.ts#L60
'dialog' is possibly 'null'.
Components (6.1.1, 2.7): app/components/primer/dialog_helpers.ts#L75
Property 'ModalDialogElement' does not exist on type 'Window & typeof globalThis'. Did you mean 'HTMLDialogElement'?
Components (6.1.1, 2.7): node_modules/@oddbird/popover-polyfill/dist/index.d.ts#L7
All declarations of 'oldState' must have identical modifiers.
Components (6.1.1, 2.7): node_modules/@oddbird/popover-polyfill/dist/index.d.ts#L8
All declarations of 'newState' must have identical modifiers.
Components (6.1.1, 2.7): node_modules/@oddbird/popover-polyfill/dist/index.d.ts#L11
Subsequent property declarations must have the same type. Property 'popover' must be of type 'string | null', but here has type '"auto" | "manual" | null'.
Components (6.1.1, 2.7): node_modules/typescript/lib/lib.dom.d.ts#L9683
Interface 'HTMLButtonElement' cannot simultaneously extend types 'PopoverInvokerElement' and 'PopoverToggleTargetElementInvoker'.
Lib (6.1.1, 2.7)
Canceling since a higher priority waiting request for 'test-refactor-dialog-to-use-dialog-internally' exists
Lib (6.1.1, 2.7): app/components/primer/dialog_helpers.ts#L46
Parameter 'event' implicitly has an 'any' type.
Lib (6.1.1, 2.7): app/components/primer/dialog_helpers.ts#L49
'dialog' is possibly 'null'.
Lib (6.1.1, 2.7): app/components/primer/dialog_helpers.ts#L52
'dialog' is possibly 'null'.
Lib (6.1.1, 2.7): app/components/primer/dialog_helpers.ts#L60
'dialog' is possibly 'null'.
Lib (6.1.1, 2.7): app/components/primer/dialog_helpers.ts#L75
Property 'ModalDialogElement' does not exist on type 'Window & typeof globalThis'. Did you mean 'HTMLDialogElement'?
Lib (6.1.1, 2.7): node_modules/@oddbird/popover-polyfill/dist/index.d.ts#L7
All declarations of 'oldState' must have identical modifiers.
Lib (6.1.1, 2.7): node_modules/@oddbird/popover-polyfill/dist/index.d.ts#L8
All declarations of 'newState' must have identical modifiers.
Lib (6.1.1, 2.7): node_modules/@oddbird/popover-polyfill/dist/index.d.ts#L11
Subsequent property declarations must have the same type. Property 'popover' must be of type 'string | null', but here has type '"auto" | "manual" | null'.
Lib (6.1.1, 2.7): node_modules/typescript/lib/lib.dom.d.ts#L9683
Interface 'HTMLButtonElement' cannot simultaneously extend types 'PopoverInvokerElement' and 'PopoverToggleTargetElementInvoker'.
Visual Regressions
Canceling since a higher priority waiting request for 'test-refactor-dialog-to-use-dialog-internally' exists
Visual Regressions: app/components/primer/dialog_helpers.ts#L46
Parameter 'event' implicitly has an 'any' type.
Visual Regressions: app/components/primer/dialog_helpers.ts#L49
'dialog' is possibly 'null'.
Visual Regressions: app/components/primer/dialog_helpers.ts#L52
'dialog' is possibly 'null'.
Visual Regressions: app/components/primer/dialog_helpers.ts#L60
'dialog' is possibly 'null'.
Visual Regressions: app/components/primer/dialog_helpers.ts#L75
Property 'ModalDialogElement' does not exist on type 'Window & typeof globalThis'. Did you mean 'HTMLDialogElement'?
Visual Regressions: node_modules/@oddbird/popover-polyfill/dist/index.d.ts#L7
All declarations of 'oldState' must have identical modifiers.
Visual Regressions: node_modules/@oddbird/popover-polyfill/dist/index.d.ts#L8
All declarations of 'newState' must have identical modifiers.
Visual Regressions: node_modules/@oddbird/popover-polyfill/dist/index.d.ts#L11
Subsequent property declarations must have the same type. Property 'popover' must be of type 'string | null', but here has type '"auto" | "manual" | null'.
Visual Regressions: node_modules/typescript/lib/lib.dom.d.ts#L9683
Interface 'HTMLButtonElement' cannot simultaneously extend types 'PopoverInvokerElement' and 'PopoverToggleTargetElementInvoker'.
Components (7.1.1, 3.2)
Canceling since a higher priority waiting request for 'test-refactor-dialog-to-use-dialog-internally' exists
Components (7.1.1, 3.2)
The operation was canceled.
Components (7.1.1, 3.2): app/components/primer/dialog_helpers.ts#L46
Parameter 'event' implicitly has an 'any' type.
Components (7.1.1, 3.2): app/components/primer/dialog_helpers.ts#L49
'dialog' is possibly 'null'.
Components (7.1.1, 3.2): app/components/primer/dialog_helpers.ts#L52
'dialog' is possibly 'null'.
Components (7.1.1, 3.2): app/components/primer/dialog_helpers.ts#L60
'dialog' is possibly 'null'.
Components (7.1.1, 3.2): app/components/primer/dialog_helpers.ts#L75
Property 'ModalDialogElement' does not exist on type 'Window & typeof globalThis'. Did you mean 'HTMLDialogElement'?
Components (7.1.1, 3.2): node_modules/@oddbird/popover-polyfill/dist/index.d.ts#L7
All declarations of 'oldState' must have identical modifiers.
Components (7.1.1, 3.2): node_modules/@oddbird/popover-polyfill/dist/index.d.ts#L8
All declarations of 'newState' must have identical modifiers.
Components (7.1.1, 3.2): node_modules/@oddbird/popover-polyfill/dist/index.d.ts#L11
Subsequent property declarations must have the same type. Property 'popover' must be of type 'string | null', but here has type '"auto" | "manual" | null'.
Components (7.1.1, 3.2): node_modules/typescript/lib/lib.dom.d.ts#L9683
Interface 'HTMLButtonElement' cannot simultaneously extend types 'PopoverInvokerElement' and 'PopoverToggleTargetElementInvoker'.
Components (main, 3.2)
Canceling since a higher priority waiting request for 'test-refactor-dialog-to-use-dialog-internally' exists
Components (main, 3.2): app/components/primer/dialog_helpers.ts#L46
Parameter 'event' implicitly has an 'any' type.
Components (main, 3.2): app/components/primer/dialog_helpers.ts#L49
'dialog' is possibly 'null'.
Components (main, 3.2): app/components/primer/dialog_helpers.ts#L52
'dialog' is possibly 'null'.
Components (main, 3.2): app/components/primer/dialog_helpers.ts#L60
'dialog' is possibly 'null'.
Components (main, 3.2): app/components/primer/dialog_helpers.ts#L75
Property 'ModalDialogElement' does not exist on type 'Window & typeof globalThis'. Did you mean 'HTMLDialogElement'?
Components (main, 3.2): node_modules/@oddbird/popover-polyfill/dist/index.d.ts#L7
All declarations of 'oldState' must have identical modifiers.
Components (main, 3.2): node_modules/@oddbird/popover-polyfill/dist/index.d.ts#L8
All declarations of 'newState' must have identical modifiers.
Components (main, 3.2): node_modules/@oddbird/popover-polyfill/dist/index.d.ts#L11
Subsequent property declarations must have the same type. Property 'popover' must be of type 'string | null', but here has type '"auto" | "manual" | null'.
Components (main, 3.2): node_modules/typescript/lib/lib.dom.d.ts#L9683
Interface 'HTMLButtonElement' cannot simultaneously extend types 'PopoverInvokerElement' and 'PopoverToggleTargetElementInvoker'.
Lib (main, 3.2)
Canceling since a higher priority waiting request for 'test-refactor-dialog-to-use-dialog-internally' exists
Lib (main, 3.2): app/components/primer/dialog_helpers.ts#L46
Parameter 'event' implicitly has an 'any' type.
Lib (main, 3.2): app/components/primer/dialog_helpers.ts#L49
'dialog' is possibly 'null'.
Lib (main, 3.2): app/components/primer/dialog_helpers.ts#L52
'dialog' is possibly 'null'.
Lib (main, 3.2): app/components/primer/dialog_helpers.ts#L60
'dialog' is possibly 'null'.
Lib (main, 3.2): app/components/primer/dialog_helpers.ts#L75
Property 'ModalDialogElement' does not exist on type 'Window & typeof globalThis'. Did you mean 'HTMLDialogElement'?
Lib (main, 3.2): node_modules/@oddbird/popover-polyfill/dist/index.d.ts#L7
All declarations of 'oldState' must have identical modifiers.
Lib (main, 3.2): node_modules/@oddbird/popover-polyfill/dist/index.d.ts#L8
All declarations of 'newState' must have identical modifiers.
Lib (main, 3.2): node_modules/@oddbird/popover-polyfill/dist/index.d.ts#L11
Subsequent property declarations must have the same type. Property 'popover' must be of type 'string | null', but here has type '"auto" | "manual" | null'.
Lib (main, 3.2): node_modules/typescript/lib/lib.dom.d.ts#L9683
Interface 'HTMLButtonElement' cannot simultaneously extend types 'PopoverInvokerElement' and 'PopoverToggleTargetElementInvoker'.
Accessibility
Canceling since a higher priority waiting request for 'test-refactor-dialog-to-use-dialog-internally' exists
Accessibility
The operation was canceled.
Accessibility: app/components/primer/dialog_helpers.ts#L46
Parameter 'event' implicitly has an 'any' type.
Accessibility: app/components/primer/dialog_helpers.ts#L49
'dialog' is possibly 'null'.
Accessibility: app/components/primer/dialog_helpers.ts#L52
'dialog' is possibly 'null'.
Accessibility: app/components/primer/dialog_helpers.ts#L60
'dialog' is possibly 'null'.
Accessibility: app/components/primer/dialog_helpers.ts#L75
Property 'ModalDialogElement' does not exist on type 'Window & typeof globalThis'. Did you mean 'HTMLDialogElement'?
Accessibility: node_modules/@oddbird/popover-polyfill/dist/index.d.ts#L7
All declarations of 'oldState' must have identical modifiers.
Accessibility: node_modules/@oddbird/popover-polyfill/dist/index.d.ts#L8
All declarations of 'newState' must have identical modifiers.
Accessibility: node_modules/@oddbird/popover-polyfill/dist/index.d.ts#L11
Subsequent property declarations must have the same type. Property 'popover' must be of type 'string | null', but here has type '"auto" | "manual" | null'.
System
Canceling since a higher priority waiting request for 'test-refactor-dialog-to-use-dialog-internally' exists
Accessibility: node_modules/typescript/lib/lib.dom.d.ts#L9683
Interface 'HTMLButtonElement' cannot simultaneously extend types 'PopoverInvokerElement' and 'PopoverToggleTargetElementInvoker'.
System: app/components/primer/dialog_helpers.ts#L46
Parameter 'event' implicitly has an 'any' type.
System: app/components/primer/dialog_helpers.ts#L49
'dialog' is possibly 'null'.
System: app/components/primer/dialog_helpers.ts#L52
'dialog' is possibly 'null'.
System: app/components/primer/dialog_helpers.ts#L60
'dialog' is possibly 'null'.
System: app/components/primer/dialog_helpers.ts#L75
Property 'ModalDialogElement' does not exist on type 'Window & typeof globalThis'. Did you mean 'HTMLDialogElement'?
System: node_modules/@oddbird/popover-polyfill/dist/index.d.ts#L7
All declarations of 'oldState' must have identical modifiers.
System: node_modules/@oddbird/popover-polyfill/dist/index.d.ts#L8
All declarations of 'newState' must have identical modifiers.
System: node_modules/@oddbird/popover-polyfill/dist/index.d.ts#L11
Subsequent property declarations must have the same type. Property 'popover' must be of type 'string | null', but here has type '"auto" | "manual" | null'.
System: node_modules/typescript/lib/lib.dom.d.ts#L9683
Interface 'HTMLButtonElement' cannot simultaneously extend types 'PopoverInvokerElement' and 'PopoverToggleTargetElementInvoker'.
System
The operation was canceled.
CSS coverage
Canceling since a higher priority waiting request for 'test-refactor-dialog-to-use-dialog-internally' exists
CSS coverage
The operation was canceled.
CSS coverage: app/components/primer/dialog_helpers.ts#L46
Parameter 'event' implicitly has an 'any' type.
CSS coverage: app/components/primer/dialog_helpers.ts#L49
'dialog' is possibly 'null'.
CSS coverage: app/components/primer/dialog_helpers.ts#L52
'dialog' is possibly 'null'.
CSS coverage: app/components/primer/dialog_helpers.ts#L60
'dialog' is possibly 'null'.
CSS coverage: app/components/primer/dialog_helpers.ts#L75
Property 'ModalDialogElement' does not exist on type 'Window & typeof globalThis'. Did you mean 'HTMLDialogElement'?
CSS coverage: node_modules/@oddbird/popover-polyfill/dist/index.d.ts#L7
All declarations of 'oldState' must have identical modifiers.
CSS coverage: node_modules/@oddbird/popover-polyfill/dist/index.d.ts#L8
All declarations of 'newState' must have identical modifiers.
CSS coverage: node_modules/@oddbird/popover-polyfill/dist/index.d.ts#L11
Subsequent property declarations must have the same type. Property 'popover' must be of type 'string | null', but here has type '"auto" | "manual" | null'.
CSS coverage: node_modules/typescript/lib/lib.dom.d.ts#L9683
Interface 'HTMLButtonElement' cannot simultaneously extend types 'PopoverInvokerElement' and 'PopoverToggleTargetElementInvoker'.
Lib (7.1.1, 3.2)
Canceling since a higher priority waiting request for 'test-refactor-dialog-to-use-dialog-internally' exists
Lib (7.1.1, 3.2): app/components/primer/dialog_helpers.ts#L46
Parameter 'event' implicitly has an 'any' type.
Lib (7.1.1, 3.2): app/components/primer/dialog_helpers.ts#L49
'dialog' is possibly 'null'.
Lib (7.1.1, 3.2): app/components/primer/dialog_helpers.ts#L52
'dialog' is possibly 'null'.
Lib (7.1.1, 3.2): app/components/primer/dialog_helpers.ts#L60
'dialog' is possibly 'null'.
Lib (7.1.1, 3.2): app/components/primer/dialog_helpers.ts#L75
Property 'ModalDialogElement' does not exist on type 'Window & typeof globalThis'. Did you mean 'HTMLDialogElement'?
Lib (7.1.1, 3.2): node_modules/@oddbird/popover-polyfill/dist/index.d.ts#L7
All declarations of 'oldState' must have identical modifiers.
Lib (7.1.1, 3.2): node_modules/@oddbird/popover-polyfill/dist/index.d.ts#L8
All declarations of 'newState' must have identical modifiers.
Lib (7.1.1, 3.2): node_modules/@oddbird/popover-polyfill/dist/index.d.ts#L11
Subsequent property declarations must have the same type. Property 'popover' must be of type 'string | null', but here has type '"auto" | "manual" | null'.
Lib (7.1.1, 3.2): node_modules/typescript/lib/lib.dom.d.ts#L9683
Interface 'HTMLButtonElement' cannot simultaneously extend types 'PopoverInvokerElement' and 'PopoverToggleTargetElementInvoker'.
Lib (7.1.1, 3.2)
The operation was canceled.
Components (main, 3.1)
Canceling since a higher priority waiting request for 'test-refactor-dialog-to-use-dialog-internally' exists
Components (main, 3.1): app/components/primer/dialog_helpers.ts#L46
Parameter 'event' implicitly has an 'any' type.
Components (main, 3.1): app/components/primer/dialog_helpers.ts#L49
'dialog' is possibly 'null'.
Components (main, 3.1): app/components/primer/dialog_helpers.ts#L52
'dialog' is possibly 'null'.
Components (main, 3.1): app/components/primer/dialog_helpers.ts#L60
'dialog' is possibly 'null'.
Components (main, 3.1): app/components/primer/dialog_helpers.ts#L75
Property 'ModalDialogElement' does not exist on type 'Window & typeof globalThis'. Did you mean 'HTMLDialogElement'?
Components (main, 3.1): node_modules/@oddbird/popover-polyfill/dist/index.d.ts#L7
All declarations of 'oldState' must have identical modifiers.
Components (main, 3.1): node_modules/@oddbird/popover-polyfill/dist/index.d.ts#L8
All declarations of 'newState' must have identical modifiers.
Components (main, 3.1): node_modules/@oddbird/popover-polyfill/dist/index.d.ts#L11
Subsequent property declarations must have the same type. Property 'popover' must be of type 'string | null', but here has type '"auto" | "manual" | null'.
Components (main, 3.1): node_modules/typescript/lib/lib.dom.d.ts#L9683
Interface 'HTMLButtonElement' cannot simultaneously extend types 'PopoverInvokerElement' and 'PopoverToggleTargetElementInvoker'.
Lib (main, 3.1)
Canceling since a higher priority waiting request for 'test-refactor-dialog-to-use-dialog-internally' exists
Lib (main, 3.1): app/components/primer/dialog_helpers.ts#L46
Parameter 'event' implicitly has an 'any' type.
Lib (main, 3.1): app/components/primer/dialog_helpers.ts#L49
'dialog' is possibly 'null'.
Lib (main, 3.1): app/components/primer/dialog_helpers.ts#L52
'dialog' is possibly 'null'.
Lib (main, 3.1): app/components/primer/dialog_helpers.ts#L60
'dialog' is possibly 'null'.
Lib (main, 3.1): app/components/primer/dialog_helpers.ts#L75
Property 'ModalDialogElement' does not exist on type 'Window & typeof globalThis'. Did you mean 'HTMLDialogElement'?
Lib (main, 3.1): node_modules/@oddbird/popover-polyfill/dist/index.d.ts#L7
All declarations of 'oldState' must have identical modifiers.
Lib (main, 3.1): node_modules/@oddbird/popover-polyfill/dist/index.d.ts#L8
All declarations of 'newState' must have identical modifiers.
Lib (main, 3.1): node_modules/@oddbird/popover-polyfill/dist/index.d.ts#L11
Subsequent property declarations must have the same type. Property 'popover' must be of type 'string | null', but here has type '"auto" | "manual" | null'.
Lib (main, 3.1): node_modules/typescript/lib/lib.dom.d.ts#L9683
Interface 'HTMLButtonElement' cannot simultaneously extend types 'PopoverInvokerElement' and 'PopoverToggleTargetElementInvoker'.