Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: sonar coverage #844

Merged
merged 9 commits into from
Apr 24, 2024
Merged

ci: sonar coverage #844

merged 9 commits into from
Apr 24, 2024

Conversation

semirp
Copy link
Contributor

@semirp semirp commented Apr 23, 2024

Description

CHKT-XXXX

  • What do these changes do?
  • Note any breaking changes and why they are necessary

Other Notes

  • Other changes that are not specifically related to the intent of the PR

Manual Testing

Add manual testing notes here if applicable, otherwise remove this section

Screenshots

If applicable, otherwise remove this section

Contributor Checklist

  • All status checks have passed prior to code review
  • I have added unit tests to a reasonable level of coverage where suitable
  • I have added UI tests to new user flows, if applicable
  • I have manually tested newly added UX
  • I have open a documentation PR, if applicable

Reviewer Checklist

  • I have verified that a suitable set of automated tests has been added
  • I have verified that the title prefix aligns to the code changes + whether a release is expected after merging the PR
  • I have verified the documentation PR aligns with this PR, if applicable

Before Merging

  • If introducing a breaking change, I have communicated it internally
  • Any related documentation PRs are ready to merge

Other Stuff

  • You can find out more about our automation checks here
  • Find out more about conventional commits here

Copy link
Contributor

github-actions bot commented Apr 23, 2024

Warnings
⚠️ This PR doesn't seem to contain any updated Unit Test 🤔. Please consider double checking it.🙏
⚠️ Please assign someone aside from CODEOWNERS (@checkout-pci-reviewers) to review this PR.

Generated by 🚫 Danger Swift against 9179ecc

Copy link
Contributor

@semirp semirp force-pushed the u/sz/sonar-coverage branch 3 times, most recently from b2b3fed to c83a601 Compare April 24, 2024 06:48
@semirp semirp changed the title test: get coverage ci: sonar coverage Apr 24, 2024
@semirp semirp requested a review from jnewc April 24, 2024 09:12
@semirp semirp force-pushed the u/sz/sonar-coverage branch 4 times, most recently from eec797e to 4a46d47 Compare April 24, 2024 11:38
@semirp semirp force-pushed the u/sz/sonar-coverage branch from 4a46d47 to cc5d741 Compare April 24, 2024 11:57
@semirp semirp requested a review from NQuinn27 April 24, 2024 13:54
@semirp semirp merged commit 93579c6 into master Apr 24, 2024
7 checks passed
@semirp semirp deleted the u/sz/sonar-coverage branch April 24, 2024 14:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants