chore: SPM unit tests #842
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Generated by 🚫 Danger Swift against ab16cb8 |
|
Appetize link: https://appetize.io/app/kphlomivkpagwqt5osw3shdoc4 |
…re no window is present
NQuinn27
reviewed
Apr 22, 2024
| @@ -4,7 +4,6 @@ on: | |||
| pull_request: | |||
| types: | |||
| - opened | |||
| - edited | |||
There was a problem hiding this comment.
🙌 Thanks for this + the above. No more rebuilds for edits 😅
NQuinn27
reviewed
Apr 22, 2024
| @@ -199,14 +199,21 @@ class WebRedirectPaymentMethodTokenizationViewModel: PaymentMethodTokenizationVi | |||
| ) | |||
|
|
|||
| Analytics.Service.record(events: [presentEvent, networkEvent]) | |||
|
|
|||
| guard UIApplication.shared.windows.count > 0 else { | |||
There was a problem hiding this comment.
Do we expect this to only fail in tests?
There was a problem hiding this comment.
... yes, in theory. In practice if it can't find a window, the user is stuck anyway and can't proceed. This will at least try to force a completion.
I'm open to other ways of doing it though. Something with an #ifdef would probably be nicer.
NQuinn27
reviewed
Apr 22, 2024
| @@ -371,7 +371,7 @@ class MockPrimerAPIConfigurationModule: PrimerAPIConfigurationModuleProtocol { | |||
|
|
|||
| // MARK: - MOCKED PROPERTIES | |||
|
|
|||
| var mockedNetworkDelay: TimeInterval = 2 | |||
| var mockedNetworkDelay: TimeInterval = 0.5 | |||
There was a problem hiding this comment.
Nice to see it go in this direction 👌
NQuinn27
approved these changes
Apr 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Some changes to CI + testing setup:
Contributor Checklist
Reviewer Checklist
Before Merging
Other Stuff