Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: Remove canImport(UIKit) from all tests #732

Merged
merged 1 commit into from
Nov 9, 2023
Merged

chore: Remove canImport(UIKit) from all tests #732

merged 1 commit into from
Nov 9, 2023

Conversation

jnewc
Copy link
Contributor

@jnewc jnewc commented Nov 8, 2023 •
edited
Loading

What this PR does

We previously removed these from the SDK. This is aligning the tests with that.

Before merging

QA

  • I manually tested this with a demo application (simulator)

@jnewc jnewc requested review from NQuinn27 and borisprimer November 8, 2023 16:57
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Nov 8, 2023

Warnings
⚠️ Please assign someone aside from CODEOWNERS (@checkout-pci-reviewers) to review this PR.

Generated by 🚫 Danger Swift against c6f22d4

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Nov 8, 2023

Appetize link: https://appetize.io/app/vekmc3zhff76eiu2yxlv7nw2gu

@jnewc jnewc merged commit 31811fb into master Nov 9, 2023
6 of 9 checks passed
@jnewc jnewc deleted the jn/remaining-uikit-canImports branch November 9, 2023 11:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@borisprimer borisprimer borisprimer approved these changes

@NQuinn27 NQuinn27 NQuinn27 approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jnewc @NQuinn27 @borisprimer