chore: livedemostore appetize builds #731
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Generated by 🚫 Danger Swift against b17c1a5 |
|
Appetize link: |
NQuinn27
commented
Nov 11, 2023
| @@ -11,7 +11,7 @@ import XCTest | |||
|
|
|||
| class PrimerBancontactCardDataManagerTests: XCTestCase { | |||
|
|
|||
| private static let expectationTimeout = 1.0 | |||
| private static let expectationTimeout = 5.0 | |||
There was a problem hiding this comment.
These were failing all through Friday so I bumped up the timeout, lets see how they do now. cc @jnewc
There was a problem hiding this comment.
Seems it was Xcode 15 that was flaky. Reverted to Xcode 14 for Appetize build + upload (as it was before), and have a note to discuss in next chapter meeting
jnewc
approved these changes
Nov 13, 2023
semirp
approved these changes
Nov 13, 2023
semirp
approved these changes
Nov 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds:
Three kinds of builds are sent to Appetize:
Preview
A preview build is published to Appetize for every PR. The livedemostore link will look like this: https://livedemostore.common.primer.io/ios/preview_731 - where the number at the end corresponds to the PR number.
Note that there will only be one build active per PR. The build is overwritten on each subsequent build - I.E the the only build available for a PR is the most recent one.
Nightly
A nightly build is is published to appetize each night along with our UI tests. The livedemostore URL looks like this: https://livedemostore.common.primer.io/ios/nightly_10.11.2023 - where the date of the build follows the
nightly_portion.Release
A release build is published to appetize along with our post-release PR merge action. The livedemostore url looks like this: https://livedemostore.common.primer.io/ios/release_2.18.0 - where the version number corresponding with the iOS SDK version is the final portion.