Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: Clean up string extension + add unit tests #718

Merged
merged 3 commits into from
Oct 27, 2023
Merged

chore: Clean up string extension + add unit tests #718

merged 3 commits into from
Oct 27, 2023

Conversation

jnewc
Copy link
Contributor

@jnewc jnewc commented Oct 25, 2023 •
edited
Loading

DEX-

What this PR does

  • Remove unused String extension functions and properties
  • Remove String extension functions and properties that are duplicates of other functions and properties
  • Add unit tests for majority of remaining methods

Before merging

QA

  • I manually tested this with a demo application (simulator)
  • I wrote unit tests for each new util-like function

@jnewc jnewc requested a review from a team as a code owner October 25, 2023 18:24
@github-actions
Copy link
Contributor

github-actions bot commented Oct 25, 2023 •
edited
Loading

Warnings
⚠️ Please assign someone aside from CODEOWNERS (@checkout-pci-reviewers) to review this PR.

Generated by 🚫 Danger Swift against c74de5a

@github-actions
Copy link
Contributor

Appetize link: https://appetize.io/app/f5lgly3s72kibiegnzrdzdlixy

semirp
semirp approved these changes Oct 26, 2023
View reviewed changes
Copy link
Contributor

@semirp semirp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PCI valid.

@jnewc jnewc merged commit 372025d into master Oct 27, 2023
5 checks passed
@jnewc jnewc deleted the jn/string-extension-cleanup branch October 27, 2023 09:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@borisprimer borisprimer borisprimer approved these changes

@semirp semirp semirp approved these changes

@NQuinn27 NQuinn27 NQuinn27 approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@jnewc @NQuinn27 @semirp @borisprimer