Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Update iOS deployment target to 14.0 in debug app project + podfile #702

Merged
merged 2 commits into from
Oct 17, 2023

Conversation

jnewc
Copy link
Contributor

@jnewc jnewc commented Oct 16, 2023

CHKT-1763

Before merging

QA

  • I manually tested this with a demo application (simulator)

@jnewc jnewc requested review from NQuinn27 and borisprimer October 16, 2023 12:35
@github-actions
Copy link
Contributor

github-actions bot commented Oct 16, 2023

Warnings
⚠️ This PR doesn't seem to contain any updated Unit Test 🤔. Please consider double checking it.🙏
⚠️ Please assign someone aside from CODEOWNERS (@checkout-pci-reviewers) to review this PR.

Generated by 🚫 Danger Swift against d046e42

@github-actions
Copy link
Contributor

github-actions bot commented Oct 16, 2023

Copy link
Contributor

@NQuinn27 NQuinn27 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jnewc
Copy link
Contributor Author

jnewc commented Oct 16, 2023

Passed here, and there's only one commit ... will re-run to see what's happening but merging after that if it's unrelated flakiness

@NQuinn27
Copy link
Contributor

Passed here, and there's only one commit ... will re-run to see what's happening but merging after that if it's unrelated flakiness

My most recent run also failed, so I think we had some flakiness. Perhaps even caused by concurrent runs? (Which we will address when moving to nightly UI tests this sprint)

@jnewc jnewc merged commit e81adcd into master Oct 17, 2023
@jnewc jnewc deleted the jn/ios-14-deployment-target branch October 17, 2023 07:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants