Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Logging interface for SDK #694

Merged
merged 62 commits into from
Nov 2, 2023
Merged

feat: Logging interface for SDK #694

merged 62 commits into from
Nov 2, 2023

Conversation

jnewc
Copy link
Contributor

@jnewc jnewc commented Sep 29, 2023

What this PR does

  • Introduce a logging interface that can be implemented by merchants
  • Implements it within the debug app

QA

  • I manually tested this with a demo application (simulator)
  • I manually tested this with a demo application (real device)
  • I wrote unit tests for each new util-like function
  • I wrote at least basic e2e tests for the new functionalities or new paths

Documentation

  • If this PR modifies the API, I updated the API Reference.
  • If this PR adds new options to the API, I wrote some documentation or guide in the online documentation

After merging

  • Make sure a new release has been pushed to Cocoapods trunk

@jnewc jnewc requested a review from a team as a code owner September 29, 2023 16:15
@github-actions
Copy link
Contributor

github-actions bot commented Sep 29, 2023

Warnings
⚠️ > Pull Request size seems relatively large. If this Pull Request contains multiple changes, please split each into separate PR will helps faster, easier review.
⚠️ Please assign someone aside from CODEOWNERS (@checkout-pci-reviewers) to review this PR.

Generated by 🚫 Danger Swift against fc37644

Copy link
Contributor

@borisprimer borisprimer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 👍

@jnewc jnewc requested review from NQuinn27 and borisprimer October 23, 2023 09:37
Copy link
Contributor

@borisprimer borisprimer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Great work!

Copy link
Contributor

@semirp semirp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

General question, if developer only use headless integration, is it enough to set Logger only on Primer object?

@jnewc
Copy link
Contributor Author

jnewc commented Oct 31, 2023

General question, if developer only use headless integration, is it enough to set Logger only on Primer object?

Yes, the logger works independently of checkout type. This is why the logger property is on the SDK singleton (Primer.shared.logger)

@semirp semirp self-requested a review October 31, 2023 16:31
@jnewc jnewc merged commit 16be7ff into master Nov 2, 2023
5 checks passed
@jnewc jnewc deleted the jn/logging-spike branch November 2, 2023 12:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

4 participants