fix: fixes ApplePay button rendering logic #685
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Generated by 🚫 Danger Swift against 22c7a7b |
|
Appetize link: https://appetize.io/app/kr6u72p34wrry72k3fiw2ekr4q |
borisprimer
force-pushed
the
bn/apple_pay_button_bug
branch
2 times, most recently
from
0e4ad0c to
73a0ec0
Compare
NQuinn27
reviewed
Oct 5, 2023
Debug App/Sources/View Controllers/MerchantSessionAndSettingsViewController.swift
Outdated
Show resolved
Hide resolved
...re/PrimerHeadlessUniversalCheckout/Models/PrimerHeadlessUniversalCheckoutPaymentMethod.swift
Outdated
Show resolved
Hide resolved
Sources/PrimerSDK/Classes/Data Models/PrimerConfiguration.swift
Outdated
Show resolved
Hide resolved
borisprimer
force-pushed
the
bn/apple_pay_button_bug
branch
from
73a0ec0 to
eedd5db
Compare
NQuinn27
changed the title
borisprimer
force-pushed
the
bn/apple_pay_button_bug
branch
2 times, most recently
from
539e2b9 to
7772a8a
Compare
borisprimer
force-pushed
the
bn/apple_pay_button_bug
branch
from
b1843e6 to
749c789
Compare
jnewc
reviewed
Oct 16, 2023
There was a problem hiding this comment.
Is there a reason it isn't filtered out as a payment method as the source? i.e. in listAvailablePaymentMethodsTypes
I think this doesn't fix the problem we discussed with different parts of the flow having a different outcome when querying whether Apple Pay is available (see diagram)
As I mentioned previously, listAvailablePaymentMethodsTypes has exactly the same filtering logic as paymentMethodConfigViewModels except for the ApplePay filtering. I don't think we want to leave this inconsistency in place.
jnewc
approved these changes
Oct 17, 2023
NQuinn27
approved these changes
Oct 17, 2023
borisprimer
force-pushed
the
bn/apple_pay_button_bug
branch
from
749c789 to
34b3659
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed a bug and added a few more config options for SDK, to show/hide ApplePay if the device is not capable of doing it, etc.
RFC