Skip to content

Commit

Permalink
fix: Adyen IDeal banks request failing (#813)
Browse files Browse the repository at this point in the history
* chore: fix adyen ideal banks request failing

* chore: fixed unit test
  • Loading branch information
StefanV-PRIMERIO authored Mar 7, 2024
1 parent 63a5f19 commit aedc434
Show file tree
Hide file tree
Showing 5 changed files with 16 additions and 15 deletions.
23 changes: 12 additions & 11 deletions Debug App/Tests/Unit Tests/v2/MockAPIClient.swift
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@ class MockPrimerAPIClient: PrimerAPIClientProtocol {
var exchangePaymentMethodTokenResult: (PrimerPaymentMethodTokenData?, Error?)?
var begin3DSAuthResult: (ThreeDS.BeginAuthResponse?, Error?)?
var continue3DSAuthResult: (ThreeDS.PostAuthResponse?, Error?)?
var listAdyenBanksResult: ([Response.Body.Adyen.Bank]?, Error?)?
var listAdyenBanksResult: (BanksListSessionResponse?, Error?)?
var listRetailOutletsResult: (RetailOutletsList?, Error?)?
var paymentResult: (Response.Body.Payment?, Error?)?
var sendAnalyticsEventsResult: (Analytics.Service.Response?, Error?)?
Expand Down Expand Up @@ -340,12 +340,12 @@ class MockPrimerAPIClient: PrimerAPIClientProtocol {
}
}
}

func listAdyenBanks(
clientToken: DecodedJWTToken,
request: Request.Body.Adyen.BanksList,
completion: @escaping (_ result: Result<[Response.Body.Adyen.Bank], Error>) -> Void
) {
completion: @escaping APICompletion<PrimerSDK.BanksListSessionResponse>)
{
guard let result = listAdyenBanksResult,
result.0 != nil || result.1 != nil
else {
Expand Down Expand Up @@ -833,13 +833,14 @@ extension MockPrimerAPIClient {
token: MockPrimerAPIClient.Samples.mockTokenizePaymentMethod,
resumeToken: "mock-resume-token",
authentication: nil)
static let mockAdyenBanks = [
Response.Body.Adyen.Bank(
id: "mock-bank-id",
name: "mock-bank-name",
iconUrlStr: "https://primer.io/bank-logo",
disabled: false)
]
static let mockAdyenBanks = BanksListSessionResponse(
result: [
Response.Body.Adyen.Bank(
id: "mock-bank-id",
name: "mock-bank-name",
iconUrlStr: "https://primer.io/bank-logo",
disabled: false)
])
static let mockListRetailOutlets = RetailOutletsList(
result: [
RetailOutletsRetail(
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -85,7 +85,7 @@ final class BanksTokenizationComponent: NSObject, LogReporter {
seal.reject(err)

case .success(let banks):
seal.fulfill(banks)
seal.fulfill(banks.result)
}
}
}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -125,7 +125,7 @@ internal class PrimerAPIClient: PrimerAPIClientProtocol {
func listAdyenBanks(
clientToken: DecodedJWTToken,
request: Request.Body.Adyen.BanksList,
completion: @escaping (Result<[Response.Body.Adyen.Bank], Error>) -> Void) {
completion: @escaping APICompletion<BanksListSessionResponse>) {
let endpoint = PrimerAPI.listAdyenBanks(clientToken: clientToken, request: request)
execute(endpoint, completion: completion)
}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -107,7 +107,7 @@ protocol PrimerAPIClientProtocol: PrimerAPIClientAnalyticsProtocol, PrimerAPICli
func listAdyenBanks(
clientToken: DecodedJWTToken,
request: Request.Body.Adyen.BanksList,
completion: @escaping APICompletion<[Response.Body.Adyen.Bank]>)
completion: @escaping APICompletion<BanksListSessionResponse>)

// MARK: Retail Outlets

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -234,7 +234,7 @@ class BankSelectorTokenizationViewModel: WebRedirectPaymentMethodTokenizationVie
seal.reject(err)

case .success(let banks):
seal.fulfill(banks)
seal.fulfill(banks.result)
}
}
}
Expand Down

0 comments on commit aedc434

Please sign in to comment.