-
Notifications
You must be signed in to change notification settings - Fork 120
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix cyclic dependency that will cause pcln-icons tests to fail in future #995
Conversation
ec27405
to
a332f28
Compare
Codecov Report
@@ Coverage Diff @@
## master #995 +/- ##
=======================================
Coverage 91.94% 91.94%
=======================================
Files 86 86
Lines 1478 1478
Branches 287 287
=======================================
Hits 1359 1359
Misses 98 98
Partials 21 21
Continue to review full report at Codecov.
|
4ae8664
to
cb460c8
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As discussed, waiting to see the rush-lib
bump as well as seeing if the snapshots calm down after a rebase.
cb460c8
to
efa34f6
Compare
09e02ff
to
d751f73
Compare
d751f73
to
63d7027
Compare
While working on #970, I noticed that
pcln-icons
tests failed after upgrading topcln-design-system@^4.2.1
. It was previously onpcln-design-system@^3
, and upgrading seemed to cause an inexplicable error when runningrush update
related to an already existent symlink topackages/icons/node_modules/pcln-design-system/dist/cjs/index.js
.This PR includes the following changes:
Use PNPM workspaces to resolve cyclic dependency issuespcln-design-system
in devDeps ofpcln-icons
react
andreact-dom
inbabel-preset
to match that of the rest of the packages in the repo. This mismatch was causing a React invalid hooks error when running tests forpcln-icons
because there would be multiple versions of React in the dependency tree.@rushstack/eslint-patch
to individual project.eslintrc.js
files as recommended in their README