Convert all stories to CSF #971
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
craigpalermo
force-pushed
the
core-stories-to-csf
branch
2 times, most recently
from
60ebece to
d35b2eb
Compare
craigpalermo
changed the title
pcln-barry
approved these changes
Nov 30, 2020
sdalonzo
reviewed
Nov 30, 2020
sdalonzo
reviewed
Nov 30, 2020
craigpalermo
force-pushed
the
core-stories-to-csf
branch
from
d35b2eb to
5ae747e
Compare
Codecov Report
@@ Coverage Diff @@
## master #971 +/- ##
==========================================
- Coverage 91.74% 91.33% -0.41%
==========================================
Files 78 78
Lines 1345 1351 +6
Branches 269 269
==========================================
Hits 1234 1234
- Misses 90 96 +6
Partials 21 21
Continue to review full report at Codecov.
|
craigpalermo
force-pushed
the
core-stories-to-csf
branch
from
5ae747e to
6c56d36
Compare
craigpalermo
force-pushed
the
core-stories-to-csf
branch
from
6c56d36 to
8090f81
Compare
sdalonzo
approved these changes
Nov 30, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is prep for #970 to make it easier to review. Long story short, the easiest way to add support for TypeScript in the
corepackage requires upgrading to Storybook 6 because it provides zero-config TS support. In order to do that, we need to remove usages of the deprecated@storybook/addon-info, and we do that by replacing those usages withparameters.docs.description.componentin the default export for CSF story files. Obviously, this requires refactoring all stories to CSF, hence this PR.This PR does not upgrade to SB6, it's just prep and will not change any functionality. The docs pages of all stories are still broken.
rush change