Add support for Core components written in TypeScript #1002
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
craigpalermo
force-pushed
the
typescript-support-2
branch
from
3a9743f to
21c02f8
Compare
Upgrade to Storybook 6
craigpalermo
force-pushed
the
typescript-support-2
branch
from
21c02f8 to
63b7d0d
Compare
|
This pull request introduces 2 alerts when merging 63b7d0d into 077030c - view on LGTM.com new alerts:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replaces #970
Changes included:
Boxcomponent and related files in TypeScripttypesprojectTracking this issue related to prop table on docsite for TS components and this issue related to missing docs page props for styled components.
Todo
rush lint:fixrush changeBox, as well as JS components