Upating linting

.github/workflows/lint.yml

@@ -13,4 +13,4 @@ jobs:
           go-version: '1.20'
       - uses: golangci/golangci-lint-action@v3
         with:
-          args: --timeout=5m
+          args: --disable=errcheck --timeout=5m

Makefile

@@ -10,10 +10,6 @@ build:
 
 # Run all lint checking with exit codes for CI
 lint:
-	golint -set_exit_status `go list ./... | grep -v /vendor/`
+	golangci-lint run --disable=errcheck --timeout=5m
 
-# Run tests with coverage reporting
-test:
-	# @todo, Unit tests for marshalling.
-
-.PHONY: build lint test
+.PHONY: build lint

internal/datasources/apps/v1/deployment/image/read.go

@@ -33,8 +33,11 @@ func Read(ctx context.Context, d *schema.ResourceData, m interface{}) diag.Diagn
 
 	deployment, err := conn.Kubernetes().AppsV1().Deployments(namespace).Get(ctx, name, metav1.GetOptions{})
 	if kerrors.IsNotFound(err) {
-		d.Set(FieldResult, fallback)
-		return nil
+		if err := d.Set(FieldResult, fallback); err != nil {
+			return diag.FromErr(err)
+		}
+
+		return diags
 	} else if err != nil {
 		return diag.FromErr(err)
 	}
@@ -51,7 +54,9 @@ func Read(ctx context.Context, d *schema.ResourceData, m interface{}) diag.Diagn
 
 	result := getImage(deployment.Spec.Template.Spec.Containers, container, fallback)
 
-	d.Set(FieldResult, result)
+	if err := d.Set(FieldResult, result); err != nil {
+		return diag.FromErr(err)
+	}
 
 	return diags
 }

internal/interfaceutils/interfaceutils.go

@@ -2,7 +2,7 @@ package interfaceutils
 
 // ExpandSlice converts an interface slice to a string slice.
 func ExpandSlice(s []interface{}) []string {
-	result := make([]string, len(s), len(s))
+	result := make([]string, len(s))
 
 	for k, v := range s {
 		result[k] = v.(string)

internal/resources/core/v1/pod/container/args/expand.go

@@ -2,7 +2,7 @@ package args
 
 // Expand will return a structured object.
 func Expand(s []interface{}) []string {
-	result := make([]string, len(s), len(s))
+	result := make([]string, len(s))
 
 	for k, v := range s {
 		result[k] = v.(string)

internal/resources/core/v1/pod/container/command/expand.go

@@ -2,7 +2,7 @@ package command
 
 // Expand will return a structured object.
 func Expand(s []interface{}) []string {
-	result := make([]string, len(s), len(s))
+	result := make([]string, len(s))
 
 	for k, v := range s {
 		result[k] = v.(string)

internal/resources/rbac/v1/role/rule/apigroups/expand.go

@@ -2,7 +2,7 @@ package apigroups
 
 // Expand will return a structured object.
 func Expand(s []interface{}) []string {
-	result := make([]string, len(s), len(s))
+	result := make([]string, len(s))
 
 	for k, v := range s {
 		if v == nil {

internal/resources/rbac/v1/role/rule/resourcenames/expand.go

@@ -2,7 +2,7 @@ package resourcenames
 
 // Expand will return a structured object.
 func Expand(s []interface{}) []string {
-	result := make([]string, len(s), len(s))
+	result := make([]string, len(s))
 
 	for k, v := range s {
 		result[k] = v.(string)

internal/resources/rbac/v1/role/rule/resources/expand.go

@@ -2,7 +2,7 @@ package resources
 
 // Expand will return a structured object.
 func Expand(s []interface{}) []string {
-	result := make([]string, len(s), len(s))
+	result := make([]string, len(s))
 
 	for k, v := range s {
 		result[k] = v.(string)

internal/resources/rbac/v1/role/rule/verbs/expand.go

@@ -2,7 +2,7 @@ package verbs
 
 // Expand will return a structured object.
 func Expand(s []interface{}) []string {
-	result := make([]string, len(s), len(s))
+	result := make([]string, len(s))
 
 	for k, v := range s {
 		result[k] = v.(string)

internal/terraform/config/config.go

@@ -8,7 +8,6 @@ import (
 	awsconfig "github.com/aws/aws-sdk-go-v2/config"
 	"github.com/aws/aws-sdk-go-v2/service/sts"
 	"github.com/hashicorp/terraform-plugin-sdk/v2/helper/schema"
-	"github.com/hashicorp/terraform/terraform"
 	"github.com/pkg/errors"
 	"k8s.io/client-go/rest"
 	"k8s.io/client-go/tools/clientcmd"
@@ -31,7 +30,7 @@ func Func(d *schema.ResourceData) (interface{}, error) {
 	cfg := &rest.Config{}
 
 	// Overriding with static configuration
-	cfg.UserAgent = fmt.Sprintf("HashiCorp/1.0 Terraform/%s", terraform.VersionString())
+	cfg.UserAgent = "HashiCorp/1.0 Terraform"
 
 	if v, ok := d.GetOk(FieldHost); ok {
 		cfg.Host = v.(string)