Fixes #29: Strong type-hints (#33)

* Fixes #29: Strong type-hints

* Modern PHP

* Add php81 executor

* Add very useful @var dec

* Bump squizlabs, ignore missing var decs

* Bump squizlabs for lowest

* Kill more var docs

Co-authored-by: Lee Rowlands <[email protected]>

.circleci/config.yml

@@ -1,20 +1,20 @@
 version: 2.1
 
 executors:
-  php74:
-    docker:
-      - image: skpr/php-cli:7.4-1.x
   php80:
     docker:
       - image: skpr/php-cli:8.0-1.x
+  php81:
+    docker:
+      - image: skpr/php-cli:8.0-1.x
 
 workflows:
   build:
     jobs:
       - build:
           matrix:
             parameters:
-              php: ["php74", "php80"]
+              php: ["php80", "php81"]
               composer-opts: ["", "--prefer-lowest"]
 
 jobs:
@@ -30,6 +30,7 @@ jobs:
       - checkout
       - run: composer2 update --prefer-dist --no-progress --no-suggest --no-interaction --optimize-autoloader << parameters.composer-opts >>
       - run: ./bin/phpcs --colors --report=full --runtime-set testVersion 8.0-
+      - run: php -d memory_limit=-1 ./bin/phpstan analyze --no-progress
       - run: mkdir -p build/phpunit
       - run: ./bin/phpunit --log-junit build/phpunit/results.xml
       - store_test_results:

.gitignore

@@ -2,3 +2,4 @@
 /vendor/
 *.sqlite
 .phpunit.result.cache
+.idea

composer.json

@@ -12,7 +12,7 @@
     "minimum-stability": "dev",
     "prefer-stable": true,
     "require": {
-        "php": "^7.3 || ^8.0",
+        "php": ">=8.0",
         "doctrine/dbal": "^2.12.1"
     },
     "require-dev": {
@@ -21,8 +21,11 @@
         "drupal/coder": "^8.3.12",
         "pear/console_table": "^1.3",
         "phpcompatibility/php-compatibility": "^9.3",
+        "phpstan/extension-installer": "^1.1",
+        "phpstan/phpstan": "^1.4",
+        "phpstan/phpstan-deprecation-rules": "^1.0",
         "phpunit/phpunit": "^8.5 || ^9.3",
-        "squizlabs/php_codesniffer": "^3.5.8"
+        "squizlabs/php_codesniffer": "^3.7.1"
     },
     "autoload": {
         "psr-4": {
@@ -39,6 +42,10 @@
         "preferred-install": {
             "*": "dist"
         },
-        "sort-packages": true
+        "sort-packages": true,
+        "allow-plugins": {
+            "dealerdirect/phpcodesniffer-composer-installer": true,
+            "phpstan/extension-installer": true
+        }
     }
 }

phpcs.xml

@@ -9,4 +9,8 @@
   <arg value="sp"/>
   <rule ref="Drupal"/>
   <rule ref="PHPCompatibility"/>
+  <!-- kill @var for properties since php now has typed props -->
+  <rule ref="Drupal.Commenting.VariableComment.Missing">
+    <severity>0</severity>
+  </rule>
 </ruleset>

phpstan.neon

@@ -0,0 +1,8 @@
+parameters:
+  level: 6
+  checkMissingIterableValueType: false
+  paths:
+    - src
+  customRulesetUsed: true
+  reportUnmatchedIgnoredErrors: false
+  ignoreErrors: {  }