Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 Fix bugs introduced by drupal/coder 8.3.24 #82

Merged
merged 2 commits into from
Jun 4, 2024
Merged

🐛 Fix bugs introduced by drupal/coder 8.3.24 #82

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
132d6e4
Empty
dpi Jun 4, 2024
f63093d
🐛 Fix bugs introduced by `drupal/coder` 8.3.24
dpi Jun 4, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 12 additions & 0 deletions PreviousNextDrupal/ruleset.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -62,6 +62,14 @@
<!-- Drupal -->
<rule ref="Drupal" />

<!-- Undo the DeclareStrictTypesMissing ignore introduced by
https://www.drupal.org/project/coder/issues/3407995
This must be placed after the above ref="Drupal"
-->
<rule ref="SlevomatCodingStandard.TypeHints.DeclareStrictTypes.DeclareStrictTypesMissing">
<severity>5</severity>
</rule>

<!-- Drupal.Arrays -->
<rule ref="Drupal.Arrays.Array.LongLineDeclaration"><severity>0</severity></rule>

Expand All @@ -77,4 +85,8 @@
<rule ref="Drupal.Commenting.TodoComment.TodoFormat"><severity>0</severity></rule>
<!-- Do not require @var for properties since PHP has property typing -->
<rule ref="Drupal.Commenting.VariableComment.Missing"><severity>0</severity></rule>

<!-- Drupal.Functions -->
<!-- This duplicates SlevomatCodingStandard.Functions.RequireTrailingCommaInDeclaration -->
<rule ref="Drupal.Functions.MultiLineFunctionDeclaration.MissingTrailingComma"><severity>0</severity></rule>
</ruleset>
2 changes: 1 addition & 1 deletion composer.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@
"require": {
"php": "^8.0",
"dealerdirect/phpcodesniffer-composer-installer": "^1.0.0",
"drupal/coder": "^8.3.21",
"drupal/coder": "^8.3.24",
"slevomat/coding-standard": "^8.13.2",
"squizlabs/php_codesniffer": "^3.7.1"
},
Expand Down
4 changes: 3 additions & 1 deletion phpstan.neon
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,4 +7,6 @@ parameters:
- %currentWorkingDirectory%/vendor/squizlabs/php_codesniffer/autoload.php
excludePaths:
- %currentWorkingDirectory%/tests/*/fixtures/*
checkGenericClassInNonGenericObjectType: false
ignoreErrors:
-
identifier: missingType.generics
Loading