Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add name to recommended config preset #692

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

ST-DDT
Copy link

@ST-DDT ST-DDT commented Nov 4, 2024

This PR adds a name to the eslint config preset.

The name will be shown in when inspecting the eslint config and for debugging purposes.

You can view the eslint preview using the following command:

npx @eslint/config-inspector@latest
UI-Diff
Before After
grafik {4B409241-20BA-411B-86C4-352989EA3FF0}

The remaining anonymous sections are from other eslint-plugin presets that don't have a name yet.

I also added the config group names to the eslint config itself for consistency.
I can revert that part if you don't like it.

Copy link

changeset-bot bot commented Nov 4, 2024

⚠️ No Changeset found

Latest commit: 1bae78f

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@JounQin
Copy link
Member

JounQin commented Nov 19, 2024

I also added the config group names to the eslint config itself for consistency.
I can revert that part if you don't like it.

Personally I don't think we need that part.

@ST-DDT
Copy link
Author

ST-DDT commented Nov 19, 2024

Personally I don't think we need that part.

Should I revert that part or should I wait for more opinions?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants