Update the payment due date for banktransfers, when the order is changed #22
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
raphaelm
reviewed
Jun 27, 2023
| @@ -101,3 +100,14 @@ def refresh_mollie_tokens(sender, **kwargs): | |||
| if rt not in seen: | |||
| refresh_mollie_token(es.object, True) | |||
| seen.add(rt) | |||
|
|
|||
|
|
|||
| @receiver(order_modified, dispatch_uid='mollie_order_modified') | |||
There was a problem hiding this comment.
pretix.base.services.orders.extend_order does not seem to trigger this signal
There was a problem hiding this comment.
Hm, that kinda makes this whole thing obsolete...
I guess we could either introduce a new expiration_changed or emit the order_changed-signal from the service. Any preference?
| headers=self.request_headers | ||
| ) | ||
| req.raise_for_status() | ||
| payment.info_data = req.json() |
There was a problem hiding this comment.
Should we create a log entry for this as well?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SEPA-Banktransfers are the only payment method at Mollie, where we actively need to communicate a due date to Mollie after which the incoming bank transfer is refused.
Some of our customers however are facing an issue, that they have to extend the payment deadline on an order to accommodate slower corporate payment processes. Doing so will however not extend the due date on the Mollie-payment - which in turn causes Mollie to return the payment to the sender.
This (untested) PR listens for the
order_changedsignal and transmits a new due date to Mollie to counter this issue.