Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(Partially) dump banks $0D and $0F #99

Merged
merged 8 commits into from
Nov 18, 2023
Merged

(Partially) dump banks $0D and $0F #99

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
053180d
Bank $0f dumping (will not build)
ZoomTen Jun 17, 2021
36c5bf7
Optimize title logo graphic
ZoomTen Jun 17, 2021
b7e8ba8
Make buildable again
ZoomTen Jun 18, 2021
7efe26d
Add some more labels to bank $0f
ZoomTen Jun 18, 2021
c99ee16
Add bank $0d, non-building
ZoomTen Jun 18, 2021
32cfd22
fix erroneous shim
ZoomTen Jun 21, 2021
a9e2d51
bank $0D dump buildable
ZoomTen Jun 21, 2021
26eb31f
Make buildable again
vulcandth Nov 18, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion data/predef_pointers.inc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,7 +46,7 @@ GiveItemPredef::
add_predef PlaceGraphic
add_predef Function3f068 ; 20
add_predef Function3f04a
add_predef Function3d08c
add_predef AnyPartyAlive
add_predef Function3d67c
add_predef Function3e1a4
add_predef Function3ef19
Expand Down
4 changes: 0 additions & 4 deletions data/types/type_matchups.asm → data/types/type_matchups.inc
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,3 @@
INCLUDE "constants.asm"

SECTION "data/types/type_matchups.asm", ROMX

TypeMatchups:
; attacker, defender, *=
db TYPE_NORMAL, TYPE_ROCK, NOT_VERY_EFFECTIVE
Expand Down
2 changes: 1 addition & 1 deletion engine/debug/field/vram_viewer.inc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -151,7 +151,7 @@ FieldDebug_DoVRAMViewer:
ld bc, $180 tiles
call ByteFill
call LoadFont
callab Function3e39f
callab Call_LoadBattleGraphics
xor a
ldh [hMapAnims], a
call EnableLCD
Expand Down
9 changes: 5 additions & 4 deletions engine/dumps/bank03.asm
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3466,8 +3466,8 @@ Textec69:

Functionec7a:
call ClearPalettes
ld hl, Function3e39f
ld a, BANK(Function3e39f)
ld hl, Call_LoadBattleGraphics
ld a, BANK(Call_LoadBattleGraphics)
call FarCall_hl
call GetMemSGBLayout
call CloseWindow
Expand Down Expand Up @@ -4424,8 +4424,9 @@ Functionf318:
call WaitBGMap
xor a
ldh [hBattleTurn], a
ld a, BANK(Function3e5bf)
ld hl, Function3e5bf
; wrong bank
ld a, $f
ld hl, Function365bf
call FarCall_hl
pop hl
pop af
Expand Down
4 changes: 2 additions & 2 deletions engine/dumps/bank0b.asm
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -226,10 +226,10 @@ asm_2d4a3:
call PlaceString
ld a, [wCurSpecies]
dec a
ld hl, Data4a8b8
ld hl, Data418b8
ld bc, $7
call AddNTimes
ld a, BANK(Data4a8b8)
ld a, BANK(Data418b8)
call GetFarByte
ld hl, $c3a0
cp $2
Expand Down
Loading