Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Comment, remove, or revise many unreferenced labels #776

Merged
merged 13 commits into from
Oct 30, 2020

Conversation

Rangi42
Copy link
Member

@Rangi42 Rangi42 commented Oct 26, 2020

These were found via unref.py: https://pastebin.com/airBsQbQ There are probably more that it didn't catch.

Some WRAM labels are not directly referenced but refer to used space, like individual struct fields; those shouldn't be commented.

This syncs with pret/pokegold#64.

@Rangi42 Rangi42 force-pushed the unreferenced branch 4 times, most recently from 96d1e15 to baa38cb Compare October 26, 2020 22:47
@entrpntr
Copy link
Contributor

Had a bunch more, but most appear to be addressed by the latest commit. I think this is all I see left (in 3 broad categories):

  1. Should be commented as unreferenced? (all from engine/gfx/pic_animation.asm; not familiar with this part of pokecrystal, but they seem to be so?)

    • AnimateMon_Menu
    • AnimateMon_Trade
    • AnimateMon_Evolve
    • AnimateMon_Hatch
    • AnimateMon_HOF
  2. Could be converted to comments:

    • BattleTowerTrainer[1-70]DataTable
    • BattleTowerMons[1-10]
  3. Miscellaneous (applies to both pokecrystal/pokegold):

    • Could combine SGBBorderMap+SGBBorderPalettes under 1 label? (like with ChrisCard+ChrisPic -> ChrisPicAndTrainerCardGFX in pokegold)
    • Could add assert of some sort before cp TrophyIDs - DecorationIDs in engine/link/mystery_gift.asm? (like with BoxNameInputUpper - NameInputUpper, since TrophyIDs only purpose seems to be in offset calculation?)

@Rangi42
Copy link
Member Author

Rangi42 commented Oct 27, 2020

AnimateMon_* are all referenced by the pokeanim macro. I've applied the rest of your comments. Thanks!

@Rangi42
Copy link
Member Author

Rangi42 commented Oct 27, 2020

Since this already started using assert, I went ahead and added more. There may be other places where assertions are appropriate, but this covers the basics that #706 listed.

@Rangi42 Rangi42 requested a review from mid-kid October 27, 2020 02:29
pokepret pushed a commit that referenced this pull request Oct 30, 2020
Comment, remove, or revise many unreferenced labels
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants