Upgrade to rgbds 0.4.0, and do miscellaneous fixes

[Rangi42]

• fail for rgbds < 0.4.0
• rst <Label>
• ds <count>, <byte>
• shift <N>
• ASCII "\r"
• Sorted .sym file

[Rangi42]

This does not yet resolve the DAYCARE/DAY_CARE inconsistency from #700 because I'm not sure which to go with. DAYCARE is more common, but in-game it's spelled "DAY-CARE".

This does not yet use LOAD/ENDL from rgbds 0.4.0 for WriteOAMDMACodeToHRAM.PushOAM and hTransferVirtualOAM because that fails to build the jr correctly.

[Rangi42]

Re: #700, I think the DAY_CARE/DAYCARE constants are already fine. Most use "DAY_CARE" to match in-game "DAY-CARE": there's ENGINE_DAY_CARE_*, EVENT_DAY_CARE_*, the DAY_CARE map, SPRITE_DAY_CARE_MON_1/2, ROUTE34_DAY_CARE_MON_1/2, etc.

There are three kinds of constant that use "DAYCARE": DAYCAREMAN/DAYCARELADY_*_F, DAYCARETEXT_*, and the object_event constants DAYCARE_GRAMPS/GRANNY. All of those are following the pattern where spaces get taken out of names for brevity. For example, NEWBARKTOWN_SILVER, BATTLETOWERTEXT_INTRO, or LUCKYNUMBERSHOW_GAME_OVER_F.

Also this doesn't need to wait for LOAD/ENDL to work properly, since WriteOAMDMACodeToHRAM.PushOAM is fine without them (the hard-coded hTransferVirtualOAM:: ds 10 size is alright for now). So this should be ready to merge.

[mid-kid]

Except for the *TEXT constants, I think object event constants and event flags constants should match their respective map's names.

[Rangi42]

EVENT_DAY_CARE_* do match map_const DAY_CARE. Do you mean that all the object_const_defs should be updated? Such as AZALEAMART_COOLTRAINER_M → AZALEA_MART_COOLTRAINER_M?

[mid-kid]

In all honesty - yes. It's kind of arbitrary to make a difference with something that's related to a very exact map. But if it's a lot, it can be left for a different PR.

[Rangi42]

If we get file-local defines (gbdev/rgbds#342), I'd like them to be even shorter: no need for the map name in every constant, with or without underscores, since they're only ever used locally in the map script.

e.g. LOCAL OBJ_COOLTRAINER_M

[mid-kid]

Agreed, it's something I wanted to consider as a result of #631, not only with defines, but also with the labels. The only two that need to be prefixed are the two that are exported, _MapScripts and _MapEvents.

[Rangi42]

Shall I change this to just -Weverything and merge?

[mid-kid]

Sure, we can change it at any point. Be sure to include it in RGBASMFLAGS though.