Make the map setup commands match the actual function names better #660
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If we're not going to prefix the decos, don't prefix any of them.
This is one weird function I'll never understand the purpose of. It could use a better name, but I have no clue what.
These functions used as map setup commands are used in other places, too, so I can't prefix them under the same. The names should match except I won't repeat "map" in a map setup command name.
Rangi42
approved these changes
Nov 18, 2019
|
Leaving this open in case you address more of #655. |
|
Should I go ahead and merge this as-is? |
|
Yeah sorry I won't get around to more anytime soon. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These functions used as map setup commands are used in other places, too,
so I can't prefix them under the same. The names should match except I
won't repeat "map" in a map setup command name.
Partially fixes #655