-
Notifications
You must be signed in to change notification settings - Fork 817
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Sectionful refactor #631
Closed
Closed
Sectionful refactor #631
Changes from 52 commits
Commits
Show all changes
74 commits
Select commit
Hold shift + click to select a range
d3b41cd
Initial section split
mid-kid 181b4c5
Split phone callees
mid-kid 14cae16
Split BlankScreen
mid-kid 1b4777e
Merge objects.asm
mid-kid 7001436
Remove useless "Crystal Sound Effects" section
mid-kid 0857f70
Further split bank $01
mid-kid d014052
Further split bank $03
mid-kid e17aba2
Further split bank $04
mid-kid 7e88727
Further split bank $09
mid-kid 01f9150
Further split bank $0e
mid-kid 0bc1e17
Further split bank $14
mid-kid ae1e8bb
Further split bank $22
mid-kid 979cca5
Forther split bank $23
mid-kid 35fba04
Further split bank $38
mid-kid 2b8bb5a
Split some questionable things
mid-kid c29a263
Final splitting pass
mid-kid 973e617
Reorganize INCLUDEs to reduce the amount of top-level files
mid-kid 4e77dd3
Restructure the battle animation core file
mid-kid f2c5503
Giving up on start menu
mid-kid 87552dd
Split intertwined map scripts
mid-kid 28bf848
"split" battle tower map scripts
mid-kid 5072712
Finish splitting all of the music
mid-kid af83b94
Forgot to split the link rooms' map scripts
mid-kid c44dc76
Add constants for BANK[] statements
mid-kid e57ed43
Do the obvious reorganizations
mid-kid 21a6233
Give all sections more proper names
mid-kid 8707481
Split out KrisBackpic
mid-kid 4fafcc9
Make engine/pokemon/evolve.asm the main file
mid-kid 0072977
Split everything into separate `.o` files
mid-kid ba6c472
Don't export every single label
mid-kid b57cd1a
Cache scan_includes output
mid-kid 63f6649
Add travis support for checking unused globals
mid-kid 1000418
First draft of optimizing includes
mid-kid d5b3b79
Create constants/music_common.inc
mid-kid c6abcec
Create constants/maps_common.inc
mid-kid af31496
Rewrite Makefile to support i18n
mid-kid 8695545
Implement makefile improvements
mid-kid e4126c6
Remove unnecessary newlines at top of files
mid-kid fcfb431
Misc changes
mid-kid 17b07a7
Make ram directory
mid-kid 3840b87
Add header guards and include dependent files where they need to be
mid-kid 5f2d8f0
Include legacy.inc where necessary
mid-kid d3948e7
Fix up the makefile to scan for sources in version/
mid-kid 7355ec4
charmap.inc is now implicitly included by macros/scripts/text.inc
mid-kid 709087c
Remove top-level ram.asm
mid-kid 51cfa80
Update travis stuff
mid-kid 3915519
Update docs/ to match .o-ification changes
mid-kid 7583b7f
Split `font.asm` from `footprints.asm`
mid-kid f15ad02
Fix build using make 3.81
mid-kid 334e46f
Tell github what highlighting to use.
mid-kid a8ab122
Fix build for Mac OSX
mid-kid 2a27be0
Cygwin is incredibly slow
mid-kid 3b5c710
Include some constants inside of maps
mid-kid d35b0a2
Forgot to fix TODOs after the fact...
mid-kid bd4abff
Fix unusedglobals.py when not ignoring anything
mid-kid 0f24d29
Rename some things back to what they were
mid-kid e16ad2f
Merge branch 'master' of https://github.com/pret/pokecrystal into spl…
mid-kid f3d3376
Remove ASCII-related bank constants
mid-kid 1cc46f3
Sort includes
mid-kid ccb0505
Export vram labels
mid-kid a3d6968
Split home/
mid-kid 6eb368a
Remove unnecessary includes
mid-kid 2761e5a
Document Makefile
mid-kid d51fd40
Merge branch 'master' of https://github.com/pret/pokecrystal into spl…
mid-kid 7e5aa33
Re-checked diffs with origin/master and fixed quirks
mid-kid 5bd33d5
Update unusedglobals.py for future rgbds
mid-kid 307e1c7
Merge branch 'master' of https://github.com/pret/pokecrystal into spl…
mid-kid ca456b5
Fix Makefile
mid-kid 75e1424
Remove .asm suffix from every section name
mid-kid 1a910fd
Move charmap.inc to constants/charmap.inc
mid-kid cedf137
Create BANK_CRYSTAL to split some files
mid-kid 6cc3ca3
Include data/items/marts in engine/items/mart
mid-kid 064c721
Split pokedex_3 further
mid-kid 786c3c0
Move tiffany's family out
mid-kid File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
The table of contents is too big for display.
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How about:
make -j`nproc`
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
(Or
make -j$(nproc)
, either works.)There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I was just following the precedent set by pokeruby, and this is a sane, easy to remember (and type!) default. How about adding this section or at least linking to it, instead?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, I guess
-j4
is a good compromise between minimal-but-slowmake
and optimal-but-long-j$(nproc)
. Please do add a section explaining the multiple and parallel builds like pokeruby has.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This depends on the amount of processors your CPU has. Would be more useful to go the nproc route imo