Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correct Moon Ball bug documentation #1133

Merged
merged 2 commits into from
Oct 17, 2024
Merged

Correct Moon Ball bug documentation #1133

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e396b4c
Modify Moon Ball patch to actually fix the issue
SnorlaxMonster Aug 22, 2024
efa2e5d
Apply suggestions from code review
Rangi42 Oct 17, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions docs/bugs_and_glitches.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1100,10 +1100,16 @@ This can occur if your party and current PC box are both full when you start the

### Moon Ball does not boost catch rate

The Moon Ball checks the wrong memory address for the wrong item ID, so no Pokémon can receive the boost.

**Fix:** Edit `MoonBallMultiplier` in [engine/items/item_effects.asm](https://github.com/pret/pokecrystal/blob/master/engine/items/item_effects.asm):

```diff
-; BUG: Moon Ball does not boost catch rate (see docs/bugs_and_glitches.md)
inc hl
- inc hl
- inc hl

push bc
ld a, BANK("Evolutions and Attacks")
call GetFarByte
Expand All @@ -1113,6 +1119,8 @@ This can occur if your party and current PC box are both full when you start the
ret nz
```

Note that this fix only accounts for Pokémon that evolve via Moon Stone as their first evolution method. However, that is sufficient to cover all Pokémon in the game that can evolve by Moon Stone.
Rangi42 marked this conversation as resolved.
Show resolved Hide resolved


### Love Ball boosts catch rate for the wrong gender

Expand Down
2 changes: 1 addition & 1 deletion engine/items/item_effects.asm
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -913,11 +913,11 @@ MoonBallMultiplier:
pop bc
ret nz

; BUG: Moon Ball does not boost catch rate (see docs/bugs_and_glitches.md)
inc hl
inc hl
inc hl

; BUG: Moon Ball does not boost catch rate (see docs/bugs_and_glitches.md)
push bc
ld a, BANK("Evolutions and Attacks")
call GetFarByte
Expand Down