Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Identify various "????"s #1125

Merged
merged 1 commit into from
Jun 12, 2024
Merged

Identify various "????"s #1125

merged 1 commit into from
Jun 12, 2024

Conversation

Rangi42
Copy link
Member

@Rangi42 Rangi42 commented Jun 12, 2024

Corresponds to pret/pokegold#116

The remaining "???"s are mostly new to Crystal (mobile-related):

audio/engine.asm:2208:	; add ??? to the next result
audio/engine.asm:2217:	; store result in ???
audio/engine.asm:2286:	; clear ???
data/battle_tower/unknown.asm:1:BattleTowerTrainerData:: ; ???
data/player_names.asm:6:	db 0 ; ???
data/player_names.asm:25:	db 0 ; ???
engine/events/battle_tower/battle_tower.asm:1387:	ld a, 0 ; ???
engine/menus/init_gender.asm:14:	res 0, a ; ???
engine/menus/init_gender.asm:17:	res 1, a ; ???
lib/mobile/main.asm:8528:	cp $8e ; LOW(MD5_K_Table + $100) ???
mobile/mobile_40.asm:242:	ret ; ???
mobile/mobile_41.asm:1034:	ld b, $0f ; no graphics at 0f:40b0; JP leftover???
mobile/mobile_46.asm:1972:	ld a, $3 ; ???
mobile/mobile_46.asm:2501:	ld a, $6 ; ???

@Rangi42 Rangi42 force-pushed the misc branch 2 times, most recently from b630abc to 96be255 Compare June 12, 2024 00:23
@Rangi42 Rangi42 merged commit 8819f7b into pret:master Jun 12, 2024
1 check passed
@Rangi42 Rangi42 deleted the misc branch June 12, 2024 00:54
github-actions bot pushed a commit that referenced this pull request Jun 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant