Use constants for VBlank handlers #1123
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks great! |
vulcandth
requested changes
May 23, 2024
| @@ -324,3 +324,16 @@ DEF DAYCARELADY_ACTIVE_F EQU 7 | |||
| const UNLOCKED_UNOWNS_S_TO_W_F | |||
| const UNLOCKED_UNOWNS_X_TO_Z_F | |||
| DEF NUM_UNLOCKED_UNOWN_SETS EQU const_value | |||
|
|
|||
| ; hVBlank:: | |||
There was a problem hiding this comment.
I wouldn't in this PR, but similarly how macros/wram.asm was renamed to macros/ram.asm we should probably rename this file to constants/ram_constants.asm if its going to hold constants used by hram.
There was a problem hiding this comment.
To do in a subsequent PR!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note that some constants would be different in G/S.