Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document Tackle is missing part of its hit animation #1104

Closed
wants to merge 1 commit into from

Conversation

vulcandth
Copy link
Collaborator

BattleAnim_Tackle in Pokémon Crystal reaches the horiztonal sprite limit due to two rows of the enemy's feet being copied from background tiles to sprites. This fix restores the animation to only copy one row like in Pokémon Gold and Silver.

data/moves/animations.asm Outdated Show resolved Hide resolved
docs/bugs_and_glitches.md Outdated Show resolved Hide resolved
docs/bugs_and_glitches.md Outdated Show resolved Hide resolved
@Idain
Copy link
Contributor

Idain commented Jan 2, 2024

Imagine I'm a collaborator. I approve.

@vulcandth vulcandth changed the title Document BattleAnim_Tackle reaches horizontal sprite limit Document Tackle is missing part of its hit animation Jan 2, 2024
@vulcandth vulcandth requested a review from Rangi42 January 2, 2024 03:46
@vulcandth
Copy link
Collaborator Author

Imagine I'm a collaborator. I approve.

Careful what you ask for.

@Idain
Copy link
Contributor

Idain commented Jan 2, 2024

I like the new explanation. It's short, but accurate.

@mid-kid
Copy link
Member

mid-kid commented Jan 3, 2024

Merged as of 3073984

@mid-kid mid-kid closed this Jan 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants