Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to RGBDS 0.7.0 #1101

Merged
merged 1 commit into from
Jan 3, 2024
Merged

Update to RGBDS 0.7.0 #1101

merged 1 commit into from
Jan 3, 2024

Conversation

Rangi42
Copy link
Member

@Rangi42 Rangi42 commented Jan 1, 2024

These new features are used from RGBDS 0.7.0:

  • Use SIZEOF and STARTOF for section types, instead of *RAM_Begin/End constants
  • Use ENDSECTION at the end of INCLUDEd files which start their own SECTIONs
    • These can be found via:
      for f in `git grep -Elw '^SECTION'`; do git grep -ho "INCLUDE \"$f\""; done
  • OAMDMACodeEnd can be .End since ENDL restores scope

Also rgbdscheck.asm is rewritten to be more robust with older versions of RGBDS. (We can't define constants since DEF is required in 0.7.0 but not yet defined in old enough versions; likewise for backslash line continuations, ELIF, etc.)

Note that the object file revision is still 9, so tools/unnamed.py did not need updating.

@Rangi42 Rangi42 requested review from mid-kid and vulcandth January 1, 2024 20:33
@vulcandth
Copy link
Collaborator

Lets also update the STYLE.md guide to mention we won't be using :: to separate multiple instructions on one line.

@Rangi42
Copy link
Member Author

Rangi42 commented Jan 1, 2024

STYLE.md was last updated two years ago and may need further changes than that; can we just do it separately?

Copy link
Collaborator

@vulcandth vulcandth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure sounds good.

rgbdscheck.asm Show resolved Hide resolved
@Rangi42 Rangi42 requested a review from mid-kid January 1, 2024 22:56
@aaaaaa123456789
Copy link
Contributor

Lets also update the STYLE.md guide to mention we won't be using :: to separate multiple instructions on one line.

This sounds unnecessary. This is already something extremely unusual, to the point "don't do it" is the default in basically every programming community for every language — if someone wants to do this, there's probably a very good reason for it.

@Rangi42 Rangi42 merged commit dbf6044 into pret:master Jan 3, 2024
1 check passed
@Rangi42 Rangi42 deleted the rgbds-0.7.0 branch January 3, 2024 15:59
github-actions bot pushed a commit that referenced this pull request Jan 3, 2024
vulcandth pushed a commit to SoupPotato/sourcrystal that referenced this pull request Jul 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants