Document SFX_RUN does not play correctly when a wild Pokemon flees from battle #1099
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
"the wrong command being used" -> "the wrong function being called" |
|
corrected, and yes it has been tested and works |
vulcandth
requested changes
Jan 2, 2024
…from battle Co-Authored-By: SoupPotato <[email protected]>
vulcandth
changed the title
Rangi42
reviewed
Jan 2, 2024
| @@ -83,6 +83,7 @@ Fixes in the [multi-player battle engine](#multi-player-battle-engine) category | |||
| - [Team Rocket battle music is not used for Executives or Scientists](#team-rocket-battle-music-is-not-used-for-executives-or-scientists) | |||
| - [No bump noise if standing on tile `$3E`](#no-bump-noise-if-standing-on-tile-3e) | |||
| - [Playing Entei's Pokédex cry can distort Raikou's and Suicune's](#playing-enteis-pok%C3%A9dex-cry-can-distort-raikous-and-suicunes) | |||
| - [`SFX_RUN` does not play correctly when a wild Pokemon flees from battle](#sfx_run-does-not-play-correctly-when-a-wild-pokemon-flees-from-battle) | |||
Rangi42
reviewed
Jan 2, 2024
|
|
||
| ### `SFX_RUN` does not play correctly when a wild Pokemon flees from battle | ||
|
|
||
| Due to the wrong function being called, `SFX_RUN` is never heard when a wild Pokemon flees from battle. |
Rangi42
reviewed
Jan 2, 2024
| (https://github.com/pret/pokecrystal/blob/master/engine/battle/core.asm): | ||
|
|
||
| ```diff | ||
| .skip_text |
vulcandth
pushed a commit
to pret/pokegold
that referenced
this pull request
Jan 2, 2024
…from battle (pret/pokecrystal#1099) Co-authored-by: SoupPotato <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated with new "
SFX_RUNdoes not play correctly when a wild Pokemon flees from battle