Skip to content
This repository has been archived by the owner on Jul 29, 2024. It is now read-only.

Update Simulation3d.pyx #38

Open
wants to merge 237 commits into
base: master
Choose a base branch
from
Open

Conversation

sally-xiyue
Copy link
Contributor

@sally-xiyue sally-xiyue commented Apr 19, 2018

Fixed when Surface Init is called to be compatible for the Arctic cases.

sally-xiyue and others added 30 commits August 27, 2015 16:47
… Kyle pointed out in theta_l output definition
@cmkaul cmkaul self-requested a review April 19, 2018 21:04
@cmkaul
Copy link
Collaborator

cmkaul commented Apr 19, 2018

It needs to be checked that moving Surface.initialize after the restart files are read does not mess up other cases (in particular, those that use a surface energy budget so that T_surface is read from the restart files). It should suffice to check that all cases that set T_surface to a prescribed initial value do so in the init function rather than in initialize...

In general, it is important to be really careful when changing the order of calls in Simulation3d.pyx! All cases need to be checked for compatibility not just whichever are currently being added/edited.

@cmkaul
Copy link
Collaborator

cmkaul commented Apr 19, 2018

Sally's comment is "Fixed when Surface update is called to be compatible for the Arctic cases." but I only see where Surface.initialize has been moved...am I missing something?

@sally-xiyue
Copy link
Contributor Author

Sorry, I meant Initialization. My bad, I'll fix the description!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants