feat: new Excel upload form and API (apache#28105)

preset-io · Apr 19, 2024 · e465876 · e465876
1 parent 37f900a
commit e465876
Show file tree

Hide file tree

Showing 31 changed files with 1,714 additions and 889 deletions.
diff --git a/RESOURCES/STANDARD_ROLES.md b/RESOURCES/STANDARD_ROLES.md
@@ -67,11 +67,10 @@ under the License.
 | can invalidate on CacheRestApi                   |:heavy_check_mark:|:heavy_check_mark:|:heavy_check_mark:|O|
 | can function names on Database                   |:heavy_check_mark:|O|O|O|
 | can csv upload on Database                       |:heavy_check_mark:|O|O|O|
+| can excel upload on Database                     |:heavy_check_mark:|O|O|O|
 | can query form data on Api                       |:heavy_check_mark:|:heavy_check_mark:|:heavy_check_mark:|O|
 | can query on Api                                 |:heavy_check_mark:|:heavy_check_mark:|:heavy_check_mark:|O|
 | can time range on Api                            |:heavy_check_mark:|:heavy_check_mark:|:heavy_check_mark:|O|
-| can this form get on ExcelToDatabaseView         |:heavy_check_mark:|:heavy_check_mark:|:heavy_check_mark:|O|
-| can this form post on ExcelToDatabaseView        |:heavy_check_mark:|:heavy_check_mark:|:heavy_check_mark:|O|
 | can external metadata on Datasource              |:heavy_check_mark:|:heavy_check_mark:|:heavy_check_mark:|O|
 | can save on Datasource                           |:heavy_check_mark:|:heavy_check_mark:|O|O|
 | can get on Datasource                            |:heavy_check_mark:|:heavy_check_mark:|:heavy_check_mark:|O|

diff --git a/superset-frontend/package-lock.json b/superset-frontend/package-lock.json
diff --git a/superset-frontend/package.json b/superset-frontend/package.json
@@ -204,6 +204,7 @@
     "use-event-callback": "^0.1.0",
     "use-immer": "^0.9.0",
     "use-query-params": "^1.1.9",
+    "xlsx": "^0.18.5",
     "yargs": "^17.7.2"
   },
   "devDependencies": {

diff --git a/...tabases/CSVUploadModal/ColumnsPreview.tsx → ...abases/UploadDataModel/ColumnsPreview.tsx b/...tabases/CSVUploadModal/ColumnsPreview.tsx → ...abases/UploadDataModel/ColumnsPreview.tsx
@@ -43,7 +43,7 @@ const ColumnsPreview: React.FC<ColumnsPreviewProps> = ({
     <StyledDivContainer>
       <Typography.Text type="secondary">Columns:</Typography.Text>
       {columns.length === 0 ? (
-        <p className="help-block">{t('Upload CSV file to preview columns')}</p>
+        <p className="help-block">{t('Upload file to preview columns')}</p>
       ) : (
         <TagsList tags={tags} maxTags={maxColumnsToShow} />
       )}

diff --git a/.../CSVUploadModal/StyledFormItemWithTip.tsx → ...UploadDataModel/StyledFormItemWithTip.tsx b/.../CSVUploadModal/StyledFormItemWithTip.tsx → ...UploadDataModel/StyledFormItemWithTip.tsx