Skip to content

Commit

Permalink
fix: GHA frontend builds fail when frontends hasn't changed (apache#3…
Browse files Browse the repository at this point in the history
  • Loading branch information
mistercrunch authored Jan 8, 2025
1 parent 210537a commit d5a4815
Showing 1 changed file with 7 additions and 5 deletions.
12 changes: 7 additions & 5 deletions .github/workflows/superset-frontend.yml
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,8 @@ env:
jobs:
frontend-build:
runs-on: ubuntu-24.04
outputs:
should-run: ${{ steps.check.outputs.frontend }}
steps:
- name: Checkout Code
uses: actions/checkout@v4
Expand Down Expand Up @@ -57,7 +59,7 @@ jobs:

sharded-jest-tests:
needs: frontend-build
if: needs.frontend-build.result == 'success'
if: needs.frontend-build.outputs.should-run == 'true'
strategy:
matrix:
shard: [1, 2, 3, 4, 5, 6, 7, 8]
Expand Down Expand Up @@ -89,7 +91,7 @@ jobs:

report-coverage:
needs: [sharded-jest-tests]
if: needs.frontend-build.result == 'success'
if: needs.frontend-build.outputs.should-run == 'true'
runs-on: ubuntu-24.04
steps:
- name: Download Coverage Artifacts
Expand All @@ -115,7 +117,7 @@ jobs:

core-cover:
needs: frontend-build
if: needs.frontend-build.result == 'success'
if: needs.frontend-build.outputs.should-run == 'true'
runs-on: ubuntu-24.04
steps:
- name: Download Docker Image Artifact
Expand All @@ -133,7 +135,7 @@ jobs:
lint-frontend:
needs: frontend-build
if: needs.frontend-build.result == 'success'
if: needs.frontend-build.outputs.should-run == 'true'
runs-on: ubuntu-24.04
steps:
- name: Download Docker Image Artifact
Expand All @@ -156,7 +158,7 @@ jobs:
validate-frontend:
needs: frontend-build
if: needs.frontend-build.result == 'success'
if: needs.frontend-build.outputs.should-run == 'true'
runs-on: ubuntu-24.04
steps:
- name: Download Docker Image Artifact
Expand Down

0 comments on commit d5a4815

Please sign in to comment.