Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add semicolon (';') as a sentence delimiter #12

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

lafrenierejm
Copy link
Contributor

Include ';' in the first regular expression grouping in l:re_term.

Include ';' in the first regular expression grouping in `l:re_term`.
@reedes
Copy link
Collaborator

reedes commented Jan 12, 2017

Thanks for the pull request.

This is different behavior from the default sentence object.

Let me think about this. It might be better as a configurable option.

@lafrenierejm
Copy link
Contributor Author

It might also be worth pointing out that the method of handling semicolons proposed by the PR does not correctly follow the grammatic definition of a sentence: it is incapable of recognizing the use of semicolons to delimit items in a list.

@alerque
Copy link
Member

alerque commented Aug 25, 2020

I agree this is useful in some circumstances but do not thing it should be the default. This should be arranged somehow similar to #17 so that it is a user configurable option. Perhaps after that is merged this could just document how to add ; as a terminator using that feature.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants