Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: When uploading, include record information #478

Merged
merged 4 commits into from
Nov 18, 2024

Conversation

huinalam
Copy link
Contributor

When uploading, include record information

Type of Change

  • New feature
  • Bug fix
  • Documentation update
  • Example update
  • Refactoring
  • Hotfix
  • Security patch
  • UI/UX improvement

Issue

[Linked issues]

Description

When uploading, include record information, such as the resource ID.
This is because it can be utilized to generate a URL when uploading a file.

Copy link

changeset-bot bot commented Oct 20, 2024

🦋 Changeset detected

Latest commit: 6f8c9df

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@premieroctet/next-admin Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@foyarash
Copy link
Collaborator

Hello

Thank you for the PR. While the feature will be working when editing a record, this will not work on a record creation as there is no id. I guess we can still have this merged with a precision in the doc about this.

Could you please run yarn changeset to generate a changeset ? Thank you

@huinalam
Copy link
Contributor Author

Thanks for the feedback!
I hope to put this project to good use as an admin in the future. Thanks for the great project!

@cregourd cregourd merged commit 9959cfd into premieroctet:main Nov 18, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants