Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added support for cd ~ #37

Merged
merged 2 commits into from
Sep 6, 2024
Merged

Added support for cd ~ #37

merged 2 commits into from
Sep 6, 2024

Conversation

prsabahrami
Copy link
Contributor

@prsabahrami prsabahrami commented Sep 6, 2024

Copy link
Contributor

@Hofer-Julian Hofer-Julian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great!

@Hofer-Julian Hofer-Julian merged commit 0a38e5d into main Sep 6, 2024
4 checks passed
@Hofer-Julian Hofer-Julian deleted the cd branch September 6, 2024 15:28
@wolfv
Copy link
Member

wolfv commented Sep 6, 2024

I am actually wondering if that's the way to do it, because I think the shell might expand the ~. Something similar might happen for glob expressions where we should pre-process the arguments before giving them to any command.

But we can also totally fix that later! :)

@prsabahrami
Copy link
Contributor Author

I am actually wondering if that's the way to do it, because I think the shell might expand the ~. Something similar might happen for glob expressions where we should pre-process the arguments before giving them to any command.

But we can also totally fix that later! :)

Ah yes, you're right.
We can fix it in another PR later.

@prsabahrami prsabahrami mentioned this pull request Sep 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants