-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat Adding support for set -e and set -x #181
base: main
Are you sure you want to change the base?
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #181 +/- ##
==========================================
- Coverage 62.64% 62.23% -0.42%
==========================================
Files 30 31 +1
Lines 3183 3217 +34
==========================================
+ Hits 1994 2002 +8
- Misses 1189 1215 +26
|
Excellent, thanks for working on this! We need this. Let's figure out how to test it. Also, I think the default should be "set -e" (exit on error), but you can turn it off with "set +e". That deviates from the default Bash behavior, however since it makes it more strict, I think it might be fine. It still leaves the door open to later relax it if we decide it should not be the default. Looking at all my scripts, I think I've always needed "set -e". @wolfv what do you think the default should be? |
It would be quite simple to change default. Also, very fair point, I think having it enabled would be more useful. |
One way to test it is like this. With
I think in Bash the whole script should succeed (we should check). While with |
Added support for
set -e