ESLint: Migrate to flat config, isolate Prettier, fix errors #120
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pavelzw
reviewed
Jun 13, 2024
.prettierignore
Outdated
| @@ -0,0 +1 @@ | |||
| dist | |||
There was a problem hiding this comment.
Suggested change
| dist | |
| dist | |
.gitignore
Outdated
| @@ -100,3 +100,6 @@ lib/**/* | |||
|
|
|||
| # Ignore jetbrains files | |||
| .idea | |||
|
|
|||
| # ESBuild metafile | |||
| metafile*.json | |||
There was a problem hiding this comment.
Suggested change
| metafile*.json | |
| metafile*.json | |
| - uses: prefix-dev/[email protected] | ||
| with: | ||
| environments: ${{ matrix.environment }} | ||
| - uses: actions/checkout@v4 |
There was a problem hiding this comment.
This is checked by prettier, right?
| throw error | ||
| }) | ||
| .then(() => exit(0)) // workaround for https://github.com/actions/toolkit/issues/1578 |
There was a problem hiding this comment.
Please keep this line, see #113
There was a problem hiding this comment.
Ok, I'll also add it to post.ts then
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi all!
This PR updates ESLint to the new flat config format. Additionally, the following things have been done:
typescript-eslintpackage.jsonto include Prettier in CI